Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phan should warn about invalid AST nodes for defaults for properties #2732

Closed
TysonAndre opened this issue May 6, 2019 · 0 comments · Fixed by #2738
Closed

Phan should warn about invalid AST nodes for defaults for properties #2732

TysonAndre opened this issue May 6, 2019 · 0 comments · Fixed by #2738
Assignees
@TysonAndre
Labels
enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan

Comments

@TysonAndre
Copy link
Member

Should run checks similar to what Phan has for class constant defaults.

class DefaultProperty {
    public $foo = $a;
}
@TysonAndre TysonAndre added enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan labels May 6, 2019
@TysonAndre TysonAndre self-assigned this May 6, 2019
TysonAndre added a commit to TysonAndre/phan that referenced this issue May 7, 2019
@TysonAndre
Check for invalid constant expressions of properties/static variables
74b6429 
Fixes phan#2732
TysonAndre added a commit to TysonAndre/phan that referenced this issue May 7, 2019
@TysonAndre
Check for invalid constant expressions of properties/static variables
ba39cb7 
Fixes phan#2732
@TysonAndre TysonAndre mentioned this issue May 7, 2019
Merged
TysonAndre added a commit to TysonAndre/phan that referenced this issue May 7, 2019
@TysonAndre
Check for invalid constant expressions of properties/static variables
b1a54db 
Fixes phan#2732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TysonAndre TysonAndre

Labels
enhancement This improves the quality of Phan's analysis of a codebase probably easy A good ticket to start with. Also see https://github.com/phan/phan/wiki/Developer%27s-Guide-To-Phan
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for invalid constant expressions of properties/static variables TysonAndre/phan
1 participant
@TysonAndre