Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about invalid arguments for undeclared internal functions #3441

Closed
TysonAndre opened this issue Nov 2, 2019 · 0 comments · Fixed by #3443
Closed

Warn about invalid arguments for undeclared internal functions #3441

TysonAndre opened this issue Nov 2, 2019 · 0 comments · Fixed by #3443
Labels
enhancement This improves the quality of Phan's analysis of a codebase

Comments

@TysonAndre
Copy link
Member

Phan knows what the signature of the internal function would be, in many cases.

Calling sapi_windows_vt100_support with too few arguments, wrong argument types, etc. should still be warned about.
@TysonAndre TysonAndre added the enhancement This improves the quality of Phan's analysis of a codebase label Nov 2, 2019
TysonAndre added a commit to TysonAndre/phan that referenced this issue Nov 2, 2019
@TysonAndre
Type check even when emitting PhanUndeclaredFunction
147561a 
This only applies to functions that Phan has signatures for,
when ignore_undeclared_functions_with_known_signatures is false.

Fixes phan#3441
@TysonAndre TysonAndre mentioned this issue Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This improves the quality of Phan's analysis of a codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type check even when emitting PhanUndeclaredFunction TysonAndre/phan
1 participant
@TysonAndre