Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go through issue types, list ones which should include the expression (e.g. PhanTypeInvalidPropertyName) #3844

Closed
TysonAndre opened this issue Apr 8, 2020 · 0 comments · Fixed by #3858
Closed

Go through issue types, list ones which should include the expression (e.g. PhanTypeInvalidPropertyName) #3844

TysonAndre opened this issue Apr 8, 2020 · 0 comments · Fixed by #3858
Labels
enhancement This improves the quality of Phan's analysis of a codebase

Comments

@TysonAndre
Copy link
Member

e.g. PhanTypeInvalidPropertyName doesn't mention which expression

PhanTypeInvalidPropertyName Saw a dynamic usage of an instance property with a name of type object but expected the name to be a string
Should be PhanTypeInvalidPropertyName Saw a dynamic usage of an instance property with a name ($prop) of type object but expected the name to be a string for $obj->$prop && $obj->$otherProp
@TysonAndre TysonAndre added the enhancement This improves the quality of Phan's analysis of a codebase label Apr 8, 2020
TysonAndre added a commit to TysonAndre/phan that referenced this issue Apr 12, 2020
@TysonAndre
Add details to more issue types
36098d6 
Fixes phan#3068
Fixes phan#3844
@TysonAndre TysonAndre mentioned this issue Apr 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This improves the quality of Phan's analysis of a codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add details to more issue types TysonAndre/phan
1 participant
@TysonAndre