Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New names not detected by stub info syncing scripts in internal/ for instance methods #4316

Closed
TysonAndre opened this issue Dec 23, 2020 · 0 comments · Fixed by #4317
Closed

New names not detected by stub info syncing scripts in internal/ for instance methods #4316

TysonAndre opened this issue Dec 23, 2020 · 0 comments · Fixed by #4317
Labels
enhancement This improves the quality of Phan's analysis of a codebase php8 Tracks changes to prepare for analyzing php 8 code

Comments

@TysonAndre
Copy link
Member

E.g. it didn't warn about the stub $inf instead of $info for the parameter names in FunctionSignatureMap.php (seen for demo site)
@TysonAndre TysonAndre added enhancement This improves the quality of Phan's analysis of a codebase php8 Tracks changes to prepare for analyzing php 8 code labels Dec 23, 2020
TysonAndre added a commit that referenced this issue Dec 23, 2020
@TysonAndre
Back to 3.2.9-dev, update param names
5a75deb 
For #4316
TysonAndre added a commit to TysonAndre/phan that referenced this issue Dec 25, 2020
@TysonAndre
Update real param names for php 8.0
23dee63 
Fixes phan#4316
@TysonAndre TysonAndre mentioned this issue Dec 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This improves the quality of Phan's analysis of a codebase php8 Tracks changes to prepare for analyzing php 8 code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update real param names for php 8.0 TysonAndre/phan
1 participant
@TysonAndre