if($var) should not modify the type of $var.

[mdeweerd]

Phan 5.4.3 .

In a CI setup, the variable '$ok' in a code that essentially is as below, the '$ok' was considered '?''|?'0'|?0|?0.0|?1|?array{}|?false(real=?''|?'0'|?0|?0.0|?1|?array{}|?false)' after the test.

$ok = 1;
include_once .... ;
foreach (...) {
    if ($ok) {
       // nullable here
      $ok = 1;
     ...
      $ok = 0;
   }
}

return $ok;  // Considered nullable

After replacing if ($ok) with if ($ok ==1), $ok no longer was nullable at any point observed with phan-debug-var.

I tried to make a test case, but I could not reproduce it.

This os tje extract from cs-style-log with phan-debug-var information showing that $ok transitions to a nullable union type;

  <error line="1146" severity="info" message="@phan-debug-var requested for variable $ok - it has union type 1(real=1)" source="PhanDebugAnnotation"/>
    <error line="1146" severity="info" message="@phan-debug-var requested for variable $ok - it has union type ?''|?'0'|?0|?0.0|?1|?array{}|?false(real=?''|?'0'|?0|?0.0|?1|?array{}|?false)" source="PhanDebugAnnotation"/>
    <error line="1148" severity="info" message="@phan-debug-var requested for variable $ok - it has union type 1(real=1)" source="PhanDebugAnnotation"/>