Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for negative string offset (< PHP 7.1) #1791

Merged
merged 9 commits into from Jun 16, 2018
Merged

Warning for negative string offset (< PHP 7.1) #1791

merged 9 commits into from Jun 16, 2018

Commits on Jun 15, 2018

  1. Merge branch 'upstream/master'

    @maksimovic
    maksimovic committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    37e28bf View commit details
    Browse the repository at this point in the history

  2. catch negative string offset for PHP < 7.1 

    @todo test
    @maksimovic
    maksimovic committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    fe990f3 View commit details
    Browse the repository at this point in the history

  3. added 7.0 tests but not sure if it's useless or not

    @maksimovic
    maksimovic committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    ce7e89d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2018

  1. handling negative string offset++ 

    - separated the check into its own method
- using type check for strings, so we don't catch arrays
- renamed the issue - it's not specific to PHP 7.0
- updated .gitignore to exclude .idea/
- updated config finder so it doesn't break when realpath() returns false
    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    ba223ec View commit details
    Browse the repository at this point in the history

  2. work in progress - the test will fail 

    also, expected values aren't real (yet)
    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    7b4555d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'upstream/master' into negative-string-offset-warning 

    # Conflicts:
#	src/Phan/Issue.php
    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    721cc4e View commit details
    Browse the repository at this point in the history

  4. renamed test files due to the collision with another PR

    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    7460ea6 View commit details
    Browse the repository at this point in the history

  5. check for negative string offset at the correct place

    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    854c0e4 View commit details
    Browse the repository at this point in the history

  6. finishing up negative string offset 

    - moved the check to the place where we're pretty sure it could be a string
- test file simplified
- cleaned up the check from ParseVisitor
    @maksimovic
    maksimovic committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    4d241ef View commit details
    Browse the repository at this point in the history