Be stricter when checking if __construct exists
#4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed when investigating phan#4320 that InferPureVisitor would cause the placeholder method to be created (depending on config settings), which would cause the warning about a missing constructor to fail to be emitted, even with no conditionals. The original bug report had `is_callable`, which Phan currently does not use to infer the existence of methods. See phan#4186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when investigating #4320 that InferPureVisitor
would cause the placeholder method to be created (depending on config
settings), which would cause the warning about a missing constructor to
fail to be emitted, even with no conditionals.
The original bug report had
is_callable, which Phan currently does notuse to infer the existence of methods. See #4186