Various render optimizations #24
Conversation
|
Are you sure this is safe? In particular iirc OBS doesn't seem to like freeing vertex buffers outside the rendering thread and will emit warnings for doing so which makes storing them kind of awkward. And just as a final note OBS caches compiled shaders internally so I don't think it recompiles every frame unless gs_effect_destroy() actually purges it from the cache (but storing the pointer would still be nice if it's safe to do so). |
|
Thanks for the feedback, you're right, the way it had been done was unsafe and was failing to free resources, as well as generally being an untidy solution. I've reworked the patch a bit so that it now builds the shader upon instance construction, acquiring the render context in order to do so, as well as rebuilding the vertex buffer in a unified way (again having acquired the render context) in |
|
I looked into how OBS does shader caching and it's true that compiled shaders are cached by name, so the performance improvement from this change will be less notable, although this change will still avoid needing to do a lookup (OBS currently stores its cached effects in a linked list so this lookup would be progressively slower the more effects have been cached with OBS). |
This patch performs various rendering optimizations, giving a minor performance improvement when using a Waveform source. As the gradient shader never changes, it does not need to be reloaded and recompiled every render frame, so this patch adds an instance member to cache the compiled shader object. The shader is loaded and compiled upon instance creation. The vertex buffers used for curve and bars rendering are cached in a similar way to avoid recreating and freeing them on every render frame. Additionally, the curve vertex buffer is pre-populated upon creation to avoid needing to update all three components of the vec3 when actually rendering, instead only updating the y component.
|
Got around to testing this and the call to create_vbuf() needs to be moved to the end of update() to avoid crashing when using rounded caps but seems good otherwise so I'll just merge it into a temp branch first. Thanks for your contribution! |
This patch performs various rendering optimizations, giving a minor performance improvement when using a Waveform source.
As the gradient shader never changes, it does not need to be reloaded and recompiled every render frame, so this patch adds an instance member to cache the compiled shader object. The shader is loaded and compiled before rendering only if it is currently NULL, allowing the compiled shader to be reused in every subsequent frame.
The vertex buffers used for curve and bars rendering are cached in a similar way to avoid recreating and freeing them on every render frame. Additionally, the curve vertex buffer is pre-populated upon creation to avoid needing to update all three components of the vec3 when actually rendering, instead only updating the y component.