Allow running ESLint without typescript on JS-only projects #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test package has no dependencies except for eslint-plugin-editorconfig, but without copying the test package outside of this project, the test package is affected by node_modules under the project root. Before this change, eslint-plugin-typescript did not work without typescript package, but I could not be noticed about it because typescript package is already installed in the node_modules under the project root although typescript is not installed in the test package itself.
Before this commit, typescript package was required even for JS-only projects. If typescript was not found, the error occured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, eslint-plugin-editorconfig does not work if
typescriptpackage is not installed, although it is not in dependencies.If
typescriptis not installed, the error occurs.To lint JS files,
typescriptis not necessary.typescriptis only required to lint TS files.This PR allows running ESLint without
typescriptpackage when ESLint is not linting any TS files.