Fix conflict against base rules #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanect
force-pushed
the
base-rules-conflict
branch
from
ace5039
to
fc7a0fd
Compare
Currently .eslintrc.js in the root directory lints files using eslint-plugin-editorconfig which includes bug to modify the original rules. Therefore, to avoid lint failure on the CI, lint in the test-packages/base-rules-conflict/ directory is temporary disabled.
phanect
force-pushed
the
base-rules-conflict
branch
from
e06d570
to
f254896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, eslint-plugin-editorconfig modifies the rule object received from
new Linter().getRules().get(baseRuleName)directly.By modifying the object, it modifies original rule object.
Therefore, if the original rule is used anywhere (e.g. in extending eslint-config-* packages), it causes error.
This PR fixes the error by cloning the base rule object before modifying it.
Closes #38