Preserve origPortRename After Qualifying Direction #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes my port renaming between Magma and CoreIR. In some cases, the port returned from port.qualify has the origPortName property stripped from it. This prevents the following line from doing the name mapping (
ref.name = port.origPortName
). Rather than requiring all qualifies to preserve this property, I'm removing the variable name reuse.The fact that qualify doesn't preserve all properties shouldn't be a problem as origPortName is made in only one place (https://github.com/phanrahan/magma/blob/master/magma/backend/coreir_.py#L146-L150) and used only here. Therefore, the ports should never be modified in between those two places. Any thoughts on how to guarantee that more strongly?