Fix 'wired to None' error message #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsetaluri
commented
Sep 6, 2018
| @@ -307,7 +307,8 @@ def is_clock_or_nested_clock(p): | |||
| if value is None and is_clock_or_nested_clock(port): | |||
| return | |||
| elif value is None: | |||
| raise Exception("Got None for port: {}, is it connected to anything?".format(port)) | |||
| raise Exception(f"Got None for port '{port.debug_name}', is it " | |||
There was a problem hiding this comment.
we should probably consolidate all error reporting in the backends. In some places we use Exceptions, in others error().
There was a problem hiding this comment.
Can you point to where we use error in the backend?
The idea was that error was used for things like wiring logic, which shouldn't terminate the program so you can see all the wiring errors. (like seeing multiple errors from a C compiler)
The backends throw exceptions because if it runs into an issue, it can't continue on (e.g. it can't compile anything), so the program should terminate.
Pull Request Test Coverage Report for Build 1071
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.