Add check for clock type in CoreIR compilation #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what we do for AysncReset types, we make a special case to be able to wire constants to clocks.
Pull Request Test Coverage Report for Build 1110
💛 - Coveralls |
|
Looks good, any chance we can get a little test for this? I think the code in the issue should work. |
|
Done |
leonardt
reviewed
Sep 18, 2018
tests/test_type/test_clock.py
Outdated
| Reset, ResetType, ResetKind, \ | ||
| Enable, EnableType, EnableKind | ||
| Reset, ResetType, ResetKind, reset \ | ||
| Enable, EnableType, EnableKind, enable \ |
There was a problem hiding this comment.
Missing end commas here I think
There was a problem hiding this comment.
Made the change via the github web ui, i'll wait for the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we do for AysncReset types, we make a special case to be
able to wire constants to clocks.