Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move isdefinition into separate file #308

Merged
merged 5 commits into from Nov 9, 2018
Merged

Move isdefinition into separate file #308

merged 5 commits into from Nov 9, 2018

Conversation

rsetaluri
Copy link
Collaborator

No description provided.

leonardt
leonardt approved these changes Oct 22, 2018
View reviewed changes
Copy link
Collaborator

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardt
Copy link
Collaborator

Looks like github is having some issues related to webhooks, which probably is why we're not seeing a build: https://status.github.com/messages

@rsetaluri
Copy link
Collaborator Author

Ah I see. I'll wait for tests to run again before merging.

@coveralls
Copy link

coveralls commented Oct 22, 2018 •
edited

Pull Request Test Coverage Report for Build 1287

  • 17 of 17 (100.0%) changed or added relevant lines in 11 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.119%
Files with Coverage Reduction New Missed Lines %
magma/backend/coreir_.py 15 87.43%
Totals Coverage Status
Change from base Build 1278: 0.05%
Covered Lines: 3505
Relevant Lines: 4860
💛 - Coveralls

@rsetaluri rsetaluri merged commit ce970a2 into master Nov 9, 2018
@rsetaluri rsetaluri deleted the magma-uniquify branch November 9, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsetaluri @leonardt @coveralls