Refactor combinational to use SSA, initial implementation of sequential #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This creates a directory magma/syntax which will hold all the logic for the available magma syntax frontends (decorators that inspect the AST) in preparation for the addition of a new sequential syntax. Test Plan: Reviewers: Subscribers: Tasks: Tags: Blame Revision: Differential Revision: https://phabricator.intern.facebook.com/D13643831
Summary: This is an initial pass at the logic for m.circuit.sequential. The intended design is to parse the `__init__` method to determine the register declarations from the user. The `__call__` method will be translated into a `m.circuit.combinational` definition that consumes the inputs to the circuits and the declared registers (contained in self) and returns the outputs of the circuits. The compiler logic will generate the surrounding magma circuit definition including an IO list, a set of register instantiations, a m.circuit.combinational definition and invocation, and the wiring of the outputs. Test Plan: Reviewers: Subscribers: Tasks: Tags: Blame Revision: Differential Revision: https://phabricator.intern.facebook.com/D13645206
Pull Request Test Coverage Report for Build 1472
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1472
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m.circuit.combinationalto use the ssa pass, this resolves the issues in m.circuit.combinational improvements #267. It also makes it easier to debug the output.m.circuit.sequentialwith a basic test