Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash #355

Merged
merged 9 commits into from
Feb 21, 2019
Merged

Fix hash #355

merged 9 commits into from
Feb 21, 2019

Commits on Feb 13, 2019

  1. Add key error test

    @rsetaluri
    rsetaluri committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    220d59a View commit details
    Browse the repository at this point in the history

  2. Make repr hash function local to uniquification

    @rsetaluri
    rsetaluri committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    6d9867d View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Only run uniquification once per definition 

    This commit fixes a bug where we would potentially call __call__ (where
the actual uniquification logic occurs) multiple times for each
definition.
    @rsetaluri
    rsetaluri committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    3d40491 View commit details
    Browse the repository at this point in the history

  2. Track definitions by id in InstanceGraphPass 

    Previously, we were keeping track of which definitions we had already
touched in the InstanceGraphPass by using definition.__name__ as a dict
key. Instead, we should now use id(definition) as multiple definitions
with the same name can exist (but they have different id's).
    @rsetaluri
    rsetaluri committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    528e51b View commit details
    Browse the repository at this point in the history

  3. Update uniquification logic 

    We previously handled how we rename duplicated circuits incorrectly.
This commit fixes that.
    @rsetaluri
    rsetaluri committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    3a1eb13 View commit details
    Browse the repository at this point in the history

  4. Fix uniquification test expectations

    @rsetaluri
    rsetaluri committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    288e0b4 View commit details
    Browse the repository at this point in the history

  5. Clean up test_key_error test

    @rsetaluri
    rsetaluri committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    e0b6905 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. Update key error test to not use mantle 

    Essentially c/p the code from mantle for creating Mux2x6. This should be
ok since it is a relatively stable component.
    @rsetaluri
    rsetaluri committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    05cdde3 View commit details
    Browse the repository at this point in the history

  2. Add missing gold file

    @rsetaluri
    rsetaluri committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    fcbecd7 View commit details
    Browse the repository at this point in the history