Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarning #371

Merged
merged 1 commit into from Mar 21, 2019
Merged

Fix DeprecationWarning #371

merged 1 commit into from Mar 21, 2019

Conversation

cdonovick
Copy link
Collaborator

Importing ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working.

@cdonovick cdonovick requested a review from leonardt March 21, 2019 01:50
@coveralls
Copy link

coveralls commented Mar 21, 2019 •
edited

Pull Request Test Coverage Report for Build 1619

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 73.269%
Totals Coverage Status
Change from base Build 1616: 0.005%
Covered Lines: 4021
Relevant Lines: 5488
💛 - Coveralls

leonardt
leonardt approved these changes Mar 21, 2019
View reviewed changes
Copy link
Collaborator

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leonardt leonardt merged commit 590a5a4 into master Mar 21, 2019
@leonardt leonardt deleted the fix-warning branch March 21, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdonovick @coveralls @leonardt