Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make debug mode optional #386

Merged
merged 10 commits into from Apr 30, 2019
Merged

Make debug mode optional #386

merged 10 commits into from Apr 30, 2019

Conversation

leonardt
Copy link
Collaborator

By default, don't call get_callee_frame_info which in turn calls inspect to get the original source line/file of wire calls and instances.

@leonardt leonardt requested a review from rsetaluri April 29, 2019 17:23
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited

Pull Request Test Coverage Report for Build 1707

  • 55 of 74 (74.32%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 72.924%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/circuit.py 18 21 85.71%
magma/port.py 8 14 57.14%
magma/syntax/combinational.py 11 21 52.38%
Totals Coverage Status
Change from base Build 1685: -0.02%
Covered Lines: 4075
Relevant Lines: 5588
💛 - Coveralls

@leonardt leonardt merged commit c3030d5 into master Apr 30, 2019
@leonardt leonardt deleted the default-nodebug branch April 30, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsetaluri rsetaluri rsetaluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonardt @coveralls @rsetaluri