Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External verilog modules #390

Merged
merged 4 commits into from May 7, 2019
Merged

External verilog modules #390

merged 4 commits into from May 7, 2019

Conversation

rsetaluri
Copy link
Collaborator

No description provided.

@rsetaluri
Add external modules parameter
37704ca 
This change enables passing in external modules referred to by parsed
verilog.
@rsetaluri
Fix from verilog issues
464d6dc
@rsetaluri
Add tests for external verilog in FromVerilog
bda6943
@rsetaluri rsetaluri requested a review from leonardt May 7, 2019 22:06
leonardt
leonardt approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented May 7, 2019 •
edited

Pull Request Test Coverage Report for Build 1728

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 73.174%
Totals Coverage Status
Change from base Build 1724: 0.02%
Covered Lines: 4127
Relevant Lines: 5640
💛 - Coveralls

rsetaluri added a commit to StanfordAHA/gemstone that referenced this pull request May 7, 2019
@rsetaluri
Allow passing external_modules to magma
3e77edf 
Depends on phanrahan/magma#390.
@rsetaluri rsetaluri merged commit 3d09fc2 into master May 7, 2019
@rsetaluri rsetaluri deleted the external-verilog-modules branch May 7, 2019 22:24
rsetaluri added a commit to StanfordAHA/gemstone that referenced this pull request May 7, 2019
@rsetaluri
Allow passing external_modules to magma
470d3e9 
Depends on phanrahan/magma#390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsetaluri @coveralls @leonardt