Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework logic for flattenning name #418

Merged
merged 2 commits into from Jun 25, 2019
Merged

Rework logic for flattenning name #418

merged 2 commits into from Jun 25, 2019

Conversation

leonardt
Copy link
Collaborator

@David-Durst I was seeing other aetherling tests fail with the recent patch to the naming logic, so I rewrote the logic based on the fault implementation and I think it makes more sense, can you review it?

I think the issue is that the coreir simulator does not flatten array of bits (but it does flatten a tuple of bits), so the we needed to rework the check for when to flatten the name.

Also let me know if you're running into other/related test failures.

@David-Durst
Copy link
Collaborator

Which Aetherling tests are you referring to? Are you running Aetherling locally?

https://travis-ci.com/David-Durst/aetherling/jobs/210898011#L649 are failing because my mantle changes haven't been released yet. I had gotten my Magma changes in but hadn't gotten around to my Mantle ones.

@David-Durst
Copy link
Collaborator

I just merged phanrahan/mantle#151. Will that automatically do a new mantle release?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1872

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 74.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/simulator/coreir_simulator.py 12 14 85.71%
Totals Coverage Status
Change from base Build 1867: -0.008%
Covered Lines: 4237
Relevant Lines: 5711

💛 - Coveralls

@leonardt
Copy link
Collaborator Author

I'll trigger a release now, in the future you can trigger one by bumping the version number in setup.py and pushing a tagged commit

@leonardt
Copy link
Collaborator Author

I was running tests/test_native_2d_line_buffer.py on aetherling master locally using the aforementioned mantle test (and need these changes for those tests to pass)

Copy link
Collaborator

@David-Durst David-Durst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the failing tests: https://travis-ci.com/David-Durst/aetherling/builds/116882840#L747.

The changes make the tests pass on my computer too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants