Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tuple indices that are integers #420

Merged
merged 1 commit into from Jun 25, 2019
Merged

Handle tuple indices that are integers #420

merged 1 commit into from Jun 25, 2019

Conversation

leonardt
Copy link
Collaborator

Fixes regression related to #415

@leonardt leonardt mentioned this pull request Jun 25, 2019
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1880

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 74.191%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/simulator/coreir_simulator.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
magma/simulator/coreir_simulator.py 1 66.97%
Totals Coverage Status
Change from base Build 1876: 0.01%
Covered Lines: 4240
Relevant Lines: 5715
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited

Pull Request Test Coverage Report for Build 1880

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 74.191%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/simulator/coreir_simulator.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
magma/simulator/coreir_simulator.py 1 66.97%
Totals Coverage Status
Change from base Build 1876: 0.01%
Covered Lines: 4240
Relevant Lines: 5715
💛 - Coveralls

David-Durst
David-Durst approved these changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator

@David-Durst David-Durst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all Aetherling tests pass when using this hotfix.

@David-Durst David-Durst merged commit f813f0b into master Jun 25, 2019
@leonardt leonardt deleted the hotfix-flattened-name branch October 30, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Durst David-Durst David-Durst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonardt @coveralls @David-Durst