Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reset N #458

Merged
merged 2 commits into from Oct 16, 2019
Merged

Add Reset N #458

merged 2 commits into from Oct 16, 2019

Conversation

jameshegarty
Copy link
Collaborator

Added reset N types (reset when signal is 0), and added comments for reset types.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2032

  • 18 of 38 (47.37%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.107%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/clock.py 18 38 47.37%
Totals Coverage Status
Change from base Build 2029: -0.2%
Covered Lines: 8672
Relevant Lines: 11702
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 15, 2019 •
edited

Pull Request Test Coverage Report for Build 2034

  • 24 of 44 (54.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.125%
Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/clock.py 22 42 52.38%
Totals Coverage Status
Change from base Build 2029: -0.2%
Covered Lines: 8680
Relevant Lines: 11710
💛 - Coveralls

phanrahan
phanrahan reviewed Oct 15, 2019
View reviewed changes
Copy link
Owner

@phanrahan phanrahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardt leonardt merged commit 846290f into master Oct 16, 2019
@leonardt leonardt deleted the resetn branch October 16, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanrahan phanrahan phanrahan left review comments

@rsetaluri rsetaluri rsetaluri approved these changes

@leonardt leonardt Awaiting requested review from leonardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jameshegarty @coveralls @phanrahan @rsetaluri @leonardt