Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for values #468

Merged
merged 1 commit into from Oct 28, 2019
Merged

Add documentation for values #468

merged 1 commit into from Oct 28, 2019

Conversation

leonardt
Copy link
Collaborator

This initializes the cheat sheet doc (inspired by https://github.com/freechipsproject/chisel-cheatsheet) with documentation on magma values. Note that I discovered a weird issue with how values currently work, which is included in the documentation. This should be fixed by the hwtypes branch, so instead of working on a patch (which requires a non trivial change to how values work), I think effort is best put into getting the hwtypes branch in which will fundamentally change how values work.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2180

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.645%

Totals Coverage Status
Change from base Build 2178: 0.0%
Covered Lines: 8832
Relevant Lines: 11832

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 28, 2019

Pull Request Test Coverage Report for Build 2180

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.645%

Totals Coverage Status
Change from base Build 2178: 0.0%
Covered Lines: 8832
Relevant Lines: 11832

💛 - Coveralls

io.O <= x
```

**NOTE** Currently magma only supports wiring two intermediate temporary values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, is this a <= issue or a more general wire() issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a wire issue (in the way the logic handles anonymous values)

@leonardt leonardt merged commit 5831ef5 into master Oct 28, 2019
@leonardt leonardt deleted the document-values branch October 28, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants