Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rename method on Filename #2

Merged
merged 2 commits into from May 9, 2020
Merged

Add rename method on Filename #2

merged 2 commits into from May 9, 2020

Conversation

MacFJA
Copy link
Contributor

@MacFJA MacFJA commented May 5, 2020

No description provided.

@MacFJA MacFJA mentioned this pull request May 9, 2020
Merged
theseer
theseer requested changes May 9, 2020
View reviewed changes
Copy link
Member

@theseer theseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Minor change though :)

src/Filename.php Outdated Show resolved Hide resolved
@MacFJA MacFJA requested a review from theseer May 9, 2020 15:11
@theseer theseer merged commit 6051c0b into phar-io:master May 9, 2020
theseer
theseer reviewed May 9, 2020
View reviewed changes
Copy link
Member

@theseer theseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged. I'll do a tiny tweak still before releasing it.

@theseer
Copy link
Member

theseer commented May 9, 2020

Okay, tagged 1.0.0 with a bunch of changes and tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseer theseer theseer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MacFJA @theseer