Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort the list of aliases alphabetically #409

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Sort the list of aliases alphabetically #409

merged 1 commit into from
Jun 15, 2023

Conversation

nicwortel
Copy link
Contributor

This will make it easier to find a specific alias in the list, and groups related aliases together.

Fixes #408.

@nicwortel
Copy link
Contributor Author

nicwortel commented Jun 15, 2023 •
edited
Loading

Screenshot of the output after this change:

image

PHPUnit tests are passing as well, but GitHub Actions don't run until the workflow is approved.

@nicwortel
Copy link
Contributor Author

It seems like the tests fail on older PHP versions because Phive tries to install PHPUnit 10 (which only supports PHP 8.1 and higher).

image

We should probably fix PHPUnit to version 9 in .github/workflows/integrate.yaml.

Shall I do so in this PR or create a separate PR for it?

@theseer
Copy link
Member

theseer commented Jun 15, 2023

It seems like the tests fail on older PHP versions because Phive tries to install PHPUnit 10 (which only supports PHP 8.1 and higher).

image

We should probably fix PHPUnit to version 9 in .github/workflows/integrate.yaml.

Shall I do so in this PR or create a separate PR for it?

Nice catch. For sake of cleanliness a separate PR is probably nicer ;)

nicwortel added a commit to nicwortel/phive that referenced this pull request Jun 15, 2023
@nicwortel
Force install PHPUnit version 9
6b1c9f1 
PHPUnit 10 does not support PHP versions < 8.1.

See phar-io#409 (comment) for context.
@nicwortel nicwortel mentioned this pull request Jun 15, 2023
Merged
nicwortel added a commit to nicwortel/phive that referenced this pull request Jun 15, 2023
@nicwortel
Force install PHPUnit version 9
f44bb9c 
PHPUnit 10 does not support PHP versions < 8.1.

See phar-io#409 (comment) for context.
theseer pushed a commit that referenced this pull request Jun 15, 2023
@nicwortel @theseer
Force install PHPUnit version 9
dfba120 
PHPUnit 10 does not support PHP versions < 8.1.

See #409 (comment) for context.
@theseer
Copy link
Member

theseer commented Jun 15, 2023

Can you rebase this so we get the change in here? :)

@nicwortel
Sort the list of aliases alphabetically
2fce9a4 
This will make it easier to find a specific alias in the list, and groups
related aliases together.

Fixes phar-io#408.
@theseer theseer merged commit 22e35df into phar-io:master Jun 15, 2023
31 checks passed
@theseer
Copy link
Member

theseer commented Jun 15, 2023

Thanks a lot!

@nicwortel nicwortel deleted the sort-aliases branch June 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort available aliases alphabetically
2 participants
@nicwortel @theseer