Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: TERMID/TERMNAME should be renamed to TERMNUM and TERMCHAR #2186

Closed
zdz2101 opened this issue Oct 24, 2023 · 0 comments · Fixed by #2241
Closed

Feature Request: TERMID/TERMNAME should be renamed to TERMNUM and TERMCHAR #2186

zdz2101 opened this issue Oct 24, 2023 · 0 comments · Fixed by #2241
Assignees
@manciniedoardo @sadchla-codes
Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented Oct 24, 2023

Feature Idea

#2010 (comment)

With respect to query-related functions in admiral, swapping out

TERMID for TERMNUM
TERMNAME for TERMCHAR

may be more informative/lead to less confusion

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@zdz2101 zdz2101 added enhancement New feature or request programming function re-work issues identified by function re-work gang - usually argument alignment, user friendliness release Q4-2023 labels Oct 24, 2023
@sadchla-codes sadchla-codes self-assigned this Oct 25, 2023
@manciniedoardo manciniedoardo self-assigned this Nov 10, 2023
manciniedoardo added a commit that referenced this issue Nov 17, 2023
@manciniedoardo
#2186 TERMID -> TERMNUM, TERMNAME -> TERMCHAR
3b2fb16
@manciniedoardo manciniedoardo mentioned this issue Nov 17, 2023
Merged
14 tasks
manciniedoardo added a commit that referenced this issue Nov 17, 2023
@manciniedoardo
#2186 chroe: styling and tests
4a4fe76
@manciniedoardo manciniedoardo mentioned this issue Nov 17, 2023
Closed
manciniedoardo added a commit that referenced this issue Nov 17, 2023
@manciniedoardo
#2186 chore: roxygen
38b046d
bundfussr added a commit that referenced this issue Nov 21, 2023
@bundfussr
#2186 term_renaming: align sdg
91f0ed2
bms63 pushed a commit that referenced this issue Nov 21, 2023
@manciniedoardo @bundfussr
Closes #2186 TERMID -> TERMNUM, TERMNAME -> TERMCHAR (#2241)
780029f 
* #2186 TERMID -> TERMNUM, TERMNAME -> TERMCHAR

* #2186 chroe: styling and tests

* #2186 chore: roxygen

* Test commit to retrigger workflow

* Undo test commit

* #2186 term_renaming: align sdg

---------

Co-authored-by: Bundfuss, Stefan {MDBB~Basel} <stefan.bundfuss@roche.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manciniedoardo manciniedoardo

@sadchla-codes sadchla-codes

Labels
enhancement New feature or request function re-work issues identified by function re-work gang - usually argument alignment, user friendliness programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2186 TERMID -> TERMNUM, TERMNAME -> TERMCHAR pharmaverse/admiral
3 participants
@zdz2101 @manciniedoardo @sadchla-codes