Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derive_vars_dt and derive_vars_dtm #492

Closed
6 tasks done
bundfussr opened this issue Aug 27, 2021 · 0 comments · Fixed by #496
Closed
6 tasks done

Update derive_vars_dt and derive_vars_dtm #492

bundfussr opened this issue Aug 27, 2021 · 0 comments · Fixed by #496
Assignees
Labels
documentation Improvements or additions to documentation programming

Comments

@bundfussr
Copy link
Collaborator

bundfussr commented Aug 27, 2021

  • “format with day and month specified as 'dd-mm': e.g. "15-06" for the 15th of June,”: it should be ‘mm-dd’ and “06-15”
  • Example “# Impute partial dates to 4th of june” must be updated because the dates are imputed to 6th of April.
  • “new_vars_prefix="AST".” should be formatted as code (new_vars_prefix parameter)
  • Add adam keyword for derive_vars_dtm
  • Remove comment in function declaration (line 551, 666, and 668)
  • The flag_imputation parameter(in derive_vars_dtm) should be case insensitive. Add a case_insensitive parameter to assert_character_scalar. If it is set to TRUE, the argument is converted to lowercase (for checking the values and returning the argument).
@bundfussr bundfussr added documentation Improvements or additions to documentation programming test release labels Aug 27, 2021
@bundfussr bundfussr self-assigned this Aug 27, 2021
@bundfussr bundfussr linked a pull request Aug 27, 2021 that will close this issue
@duniek duniek closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation programming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants