Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Increase test coverage for compat_friendly_type.R #101

Closed
bms63 opened this issue Sep 22, 2022 · 3 comments · Fixed by #157
Closed

General Issue: Increase test coverage for compat_friendly_type.R #101

bms63 opened this issue Sep 22, 2022 · 3 comments · Fixed by #157
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Sep 22, 2022

Background Information

We need to increase test coverage for our functions. The below screenshot has the function and gap in test coverage that we need to write additional unit tests for compat_friendly_type.R.

Unsure if this is a good one for us to tackle. @thomas-neitmann @bundfussr. I'm still not entirely clear why we import these functions (3.6?) . But should we build some tests around these gaps?

image

Definition of Done

New tests written that covers the red gap area for compat_friendly_type.R

Use devtools::test_coverage() to reproduce the report

@zdz2101 zdz2101 self-assigned this Oct 31, 2022
@zdz2101
Copy link
Collaborator

zdz2101 commented Oct 31, 2022

Tracking the use-case, the code chunks highlighted above are used to display user-friendly messages in a couple of the assert functions, in particular, assert_date_var() and assert_date_vector() which are still in use by many admiral derive_ functions

@zdz2101
Copy link
Collaborator

zdz2101 commented Nov 3, 2022

Image

Image

I got to this point but not sure how to get to the last bit of cases

@bms63
Copy link
Collaborator Author

bms63 commented Nov 4, 2022

I think that this is amazing progress!! Let's just merge those in and call it a day.

@zdz2101 zdz2101 linked a pull request Nov 4, 2022 that will close this issue
14 tasks
zdz2101 pushed a commit that referenced this issue Nov 4, 2022
@bms63 bms63 closed this as completed in d966ac0 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment