Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update PR Checklist Template (Edge Unit Tests and keywords/families) #172

Closed
zdz2101 opened this issue Nov 15, 2022 · 0 comments · Fixed by #173
Closed

Documentation: Update PR Checklist Template (Edge Unit Tests and keywords/families) #172

zdz2101 opened this issue Nov 15, 2022 · 0 comments · Fixed by #173
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented Nov 15, 2022

Please select a category the issue is focused on?

Other

Let us know where something needs a refresh or put your idea here!

Equivalent to pharmaverse/admiral#1331 but for admiraldev repo

PR checklist should include a nudge towards developers looking at edge cases in their tests, e.g. empty datasets, errors, etc.

PR checklist should also include a link to the list of approved keywords and families allowed in an admiral function. Developers and reviewers should adhere to this list. If a new one is needed, then a proposal should be made.

@zdz2101 zdz2101 added documentation Improvements or additions to documentation release Q4-2022 labels Nov 15, 2022
@zdz2101 zdz2101 self-assigned this Nov 15, 2022
zdz2101 pushed a commit that referenced this issue Nov 15, 2022
@bms63 bms63 closed this as completed in 65cdf9a Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
1 participant