General Issue: Increase test coverage for functions in assertions.R

[bms63]

Background Information

We need to increase test coverage for our functions. The below screenshot has the function and gap in test coverage that we need to write additional unit tests

Most of these gaps surround the messages a user receives when something goes awry.

Definition of Done

Unit tests are written that increase the coverage of the assertions.R file

[bms63]

You can get this report by running devtools::test_coverage()

[AniaGolab]

Hi @bms63 and @thomas-neitmann, while adding some unit tests I came across assert_character_scalar function. Just wanted to let you know that it appears that the values parameter can only take a vector of lower case letters. It throws an error if values are c("Test") or c("TEST") but it works for c("test"). Is this the desired behavior? If so, should we maybe add a note to the function description that the values should be lowercase? thank you!

[bundfussr]

@AniaGolab , good catch!
I assume the issue occurs when using case_sensitive = FALSE.
I think we should change

  if (!case_sensitive) {
    arg <- tolower(arg)
  }

to

  if (!case_sensitive) {
    arg <- tolower(arg)
    if (!is.null(values) {
      values <- tolower(values)
    }
  }

However, I would recommend specifying values as lower case values if case_sensitive = FALSE is used because arg is changed to lower case. So whenever you have conditions on the argument in the function code, lower case values must be used.
For me

  mode <- assert_character_scalar(mode, values = c("first", "last"), case_sensitive = FALSE)
  if (mode == "first") {

reads better than

  mode <- assert_character_scalar(mode, values = c("FIRST", "LAST"), case_sensitive = FALSE)
  if (mode == "first") {

[AniaGolab]

Thank you @bundfussr, that indeed makes sense! I will apply those changes in my commit.