Closes #94 tests for assertionsr@devel #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
editted assert_character_scalar to account for uppercase values and added instructions to make sure users only use lowercase values.
AniaGolab
changed the title
|
|
HI @bms63 and @thomas-neitmann, I added 57 tests on assertions.r with overall 100% test coverage. I also added a description to the values of the assert_character_scalar and in the assert_character_scalar itself in the assertions.r. Please let me know if you want me to add this change into the NEWS function too? Or if you have any other feedback. Thank you :) |
|
Wow. You have single-handedly increased the test coverage from 50% to 90%! A true admiral legend |
bms63
reviewed
Oct 30, 2022
bms63
reviewed
Oct 30, 2022
bms63
reviewed
Oct 30, 2022
bms63
reviewed
Oct 30, 2022
bms63
reviewed
Oct 30, 2022
bms63
reviewed
Oct 30, 2022
bms63
requested changes
Oct 30, 2022
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
2. library(admiral.test) removed. 3. added 2 more checks for new function added => currently at 100% in coverage on assertions.R.
|
Thank you for the comments Ben! I applied the changes, please let me know if there is anything else to edit :) |
bms63
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Many thanks for this @AniaGolab. You single-handedly brought us from 40% to 90% test coverage!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
develbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()