Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Increase test coverage for dataset_vignette.R #96

Closed
bms63 opened this issue Sep 22, 2022 · 0 comments · Fixed by #120
Closed

General Issue: Increase test coverage for dataset_vignette.R #96

bms63 opened this issue Sep 22, 2022 · 0 comments · Fixed by #120
Assignees
@zdz2101
Labels
good first issue Good for newcomers

Comments

@bms63
Copy link
Collaborator

bms63 commented Sep 22, 2022

Background Information

We need to increase test coverage for our functions. The below screenshot has the function and gap in test coverage that we need to write additional unit tests.

image

Definition of Done

New test written that covers the red gap area for this function.

You can get this report by running devtools::test_coverage()
@bms63 bms63 changed the title General Issue: <Insert Issue Title Here> General Issue: Increase test coverage for dataset_vignette.R Sep 22, 2022
@zdz2101 zdz2101 self-assigned this Oct 12, 2022
@zdz2101 zdz2101 linked a pull request Oct 12, 2022 that will close this issue
Closes #96 general issue increase test coverage for dataset_vignette.R #120
Merged
14 tasks
@bms63 bms63 mentioned this issue Oct 13, 2022
Merged
14 tasks
zdz2101 added a commit that referenced this issue Oct 13, 2022
@zdz2101
#96 - grammar fix output to outputted
c1ec6dd
@bms63 bms63 closed this as completed in c78e0ef Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
good first issue Good for newcomers
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
2 participants
@bms63 @zdz2101