Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub flow #349

Merged
merged 35 commits into from
Nov 17, 2023
Merged

GitHub flow #349

merged 35 commits into from
Nov 17, 2023

Commits on Jun 12, 2023

  1. docs: #283 update description and news

    Zelos Zhu committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    07bfe36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71b06b3 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #284 from pharmaverse/283_news_description_postrel…

    …ease_tidying@devel
    
    Closes #283 update description and news as post-release cleanup tasks
    bms63 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    8af2f65 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. closes #286 commit messaging, new r-cmd vignette (#291)

    * docs: #286 commit messaging, new r-cmd vignette
    
    * chore: #286 spelling
    
    * docs: #286 squash and merge blurb
    
    * Update vignettes/git_usage.Rmd
    
    Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
    
    * chore: #286 news update
    
    ---------
    
    Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
    bms63 and zdz2101 committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bd240ad View commit details
    Browse the repository at this point in the history
  2. Closes #271, #213, #260, #240 Documentation Update of get_datasets();…

    … keep_source_vars argument; @family tag; compute_ functions (#287)
    
    * docs: #271 #213 clarify get_datasets and add keep_source_vars to prog strat
    
    * docs: #260 cleanup @family mentions
    
    * docs: #240 add blurb about compute functions
    
    * docs: #271 #213 #240 #260 add news blurb
    
    * adopt suggestion for family/keywords
    
    Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
    
    * docs #271 adopt get_dataset feedback
    
    * docs: #213 #240 adopt recommendations from PR
    
    * chore: #240 add BMI to WORDLIST for spellcheck
    
    * chore: #271 #213 #260 adopt feedback
    
    ---------
    
    Co-authored-by: Zelos Zhu <zdz2101@github.com>
    Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
    3 people committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    962b9da View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Closes #264, #288 cleanup assertions and continue deprecation process (

    …#289)
    
    * feat: #288 cleanup deprecation process
    
    * feat: #264 deprecate assert_function
    
    * test: #264 cleanup some tests in assert_function, confused how others would go
    
    * test: #264 rewrite tests in a more logical way
    
    * chore: #264 run styler/lintr
    
    * chore: #288 revert back to devel test file
    
    * chore: #288 properly fix assert_order_vars again
    
    * feat: #264 begin deprecation of redundant assertions
    
    * feat: #288 deprecate assert_named_exprs
    
    * deprecate assert_has_variables properly #264
    
    * chore: #264 run styler
    
    * docs: #264 add blurb in news for the deprecated assertions
    
    * chore: #264 fix description version and remove deprecated examples
    
    ---------
    
    Co-authored-by: Zelos Zhu <zdz2101@github.com>
    zdz2101 and Zelos Zhu committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    80dcf7f View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Propagate renv.lock from pharmaverse/admiralci (#294)

    renv update from pharmaverse/admiralci
    
    Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com>
    pharmaverse-bot and dgrassellyb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    d218980 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Closes #22 #181 #201 #292 #298 Variety of small-scale general documen…

    …tation updates (#303)
    
    * feat: #22 add documentation to friendly_type_of
    
    * feat: #181 add the appropriate URL
    
    * feat: #201 #292 add documentation about PR guidance and codeowners
    
    * chore: update wordlist for codeowners
    
    * chore: add NEWS
    
    ---------
    
    Co-authored-by: Zelos Zhu <zdz2101@github.com>
    zdz2101 and Zelos Zhu committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4f9d68b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Closes #302 Adding Snapshot testing guidance to unit testing vignette (

    …#308)
    
    * Update unit_test_guidance.Rmd
    
    * Update NEWS.md
    
    * Update NEWS.md
    ddsjoberg committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4f6350e View commit details
    Browse the repository at this point in the history
  2. Closes #301: (#307)

    * #301: edoardo added as author, and author/contributor distinction implemented as in core admiral package
    
    * #301 chore: document
    manciniedoardo committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c8eec9e View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Propagate renv.lock from pharmaverse/admiralci (#310)

    * renv / codespaces update from pharmaverse/admiralci
    
    ---------
    
    Co-authored-by: galachad <galachad@users.noreply.github.com>
    Co-authored-by: Adam Foryś <adam.forys@gmail.com>
    3 people committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    64c6618 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Closes #295 template documentation@devel (#300)

    * #295 set up package extension guidance page
    
    * #295 fix vignetteindexentry
    
    * #295 chore: spellcheck
    
    * #295 chore: fix encoding issues in vignettes that prevented package from being built
    
    * #295: updates following review
    
    * #295 Chore: spellcheck
    
    * Update vignettes/package_extensions.Rmd
    
    Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com>
    
    * #295 update to refer to admiraldev devel site
    
    * #295 Chore: spellcheck
    
    ---------
    
    Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com>
    manciniedoardo and rossfarrugia committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    44f53cd View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Closes #296 document_missing_value_s@devel (#311)

    * #296 - `missing_value` and `missing_values` added to the table of common arguments.
    
    * #296 - add in discussion of when to use singular vs plural arguments to programming strategy.
    
    * #296 - run checks required for PR and update NEWS.md.
    
    * #296 - Update according to requested changes.
    
    * #296 - revert the 'wrapped' changes in the programming strategy vignette
    
    * #296 - re-insert the new text into the programming strategy vignette, altered according to changes requested.
    
    * #296 - update NEWS.md with changes requested and run the required checks for PR.
    sophie-gem committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    341863b View commit details
    Browse the repository at this point in the history
  2. Closes #282: Test Data Guidance vignette (#293)

    * #282: add test_data_guidance.Rmd, copy from admiraldata README devel
    
    * #282: update .yml
    
    * #282: add link for packages, remove SDTM, add naming conventions for program name
    
    * #282 spelling
    
    * #282: link to two data packages
    
    * #282: updated wordlist
    
    * #282: update pharmaverseadam description
    
    ---------
    
    Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
    kaz462 and manciniedoardo committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cd6ffc2 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Propagate renv.lock from pharmaverse/admiralci (#314)

    renv / codespaces update from pharmaverse/admiralci
    
    Co-authored-by: galachad <galachad@users.noreply.github.com>
    pharmaverse-bot and galachad committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3e96248 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Propagate renv.lock from pharmaverse/admiralci (#315)

    * renv / codespaces update from pharmaverse/admiralci
    
    * renv / codespaces update from pharmaverse/admiralci
    
    ---------
    
    Co-authored-by: galachad <galachad@users.noreply.github.com>
    pharmaverse-bot and galachad committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    503ffcd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Closes #306 argument descriptions added to table (#320)

    argument descriptions added to table
    
    Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
    StefanThoma and zdz2101 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0a278a8 View commit details
    Browse the repository at this point in the history
  2. Closes #316 remove messaging that includes "-" as year not handled (#317

    )
    
    * feat: #316 remove messaging that includes "-" as year not handled
    
    * feat: #316 replace warning message
    
    * chore: #316 fix warning message and typos
    
    * chore: #316 add news blurb
    
    ---------
    
    Co-authored-by: Zelos Zhu <zdz2101@github.com>
    zdz2101 and Zelos Zhu committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c3d1237 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Closes #318 #321 Documentation updates around admiral.test, staged de…

    …pendencies, and function arguments (#323)
    zdz2101 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e4eca25 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Fix hardcoded URL (#326)

    Resolves #325
    cicdguy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    390dc59 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Closes #312 breakup wall of text (#319)

    * brick in the wall
    
    * remove special characters from image name
    
    * remove special characters from image name
    
    * replaced iframe with png
    
    * fixed image reference
    
    ---------
    
    Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
    StefanThoma and zdz2101 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6fc9925 View commit details
    Browse the repository at this point in the history
  2. Closes #328 add missing news entries (#329)

    * feat: #295 add missing news entries
    
    * feat: #295 add missing news entries
    
    * fixed it
    
    * feat: add news entry for #306
    
    * chore: #312 missing reference
    
    * chore: fix link that pointed to merged branch and use devel
    
    * Update NEWS.md
    
    ---------
    
    Co-authored-by: Zelos Zhu <zdz2101@github.com>
    Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
    3 people committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9cb0a46 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. GitFlow Migration

    ddsjoberg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9ce44a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    6aa6e41 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    4f0aa71 View commit details
    Browse the repository at this point in the history
  2. Update release_strategy.Rmd

    ddsjoberg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    aa2c0cd View commit details
    Browse the repository at this point in the history
  3. progress

    ddsjoberg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d26067b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    75872a4 View commit details
    Browse the repository at this point in the history
  2. chore: branch image and main

    bms63 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    6c3b927 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d98f83 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    c2c2545 View commit details
    Browse the repository at this point in the history
  2. chore: delete dev process

    bms63 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    dbf5be3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    11acfba View commit details
    Browse the repository at this point in the history
  4. chore: new blurb for the people

    bms63 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    672e388 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7815066 View commit details
    Browse the repository at this point in the history