Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Update vignettes and templates with respect to admiral 0.11.0 #216

Closed
bundfussr opened this issue May 15, 2023 · 1 comment · Fixed by #225
Closed

General Issue: Update vignettes and templates with respect to admiral 0.11.0 #216

bundfussr opened this issue May 15, 2023 · 1 comment · Fixed by #225
Assignees
@bundfussr
Labels
Documentation Material that provides official information or evidence or that serves as a record. release Q2-2023
Projects
admiralonco Project Board

Comments

@bundfussr
Copy link
Collaborator

Background Information

Vignettes and templates should be reviewed and updated with respect the the upcomming admiral version (0.11.0). E.g.

  • derive_param_extreme_event() was deprecated
  • expressions are allowed now.

Definition of Done

Vignettes and templates are up to date and do not issue deprecation warnings.
@bundfussr bundfussr added Documentation Material that provides official information or evidence or that serves as a record. release Q2-2023 labels May 15, 2023
@bundfussr bundfussr self-assigned this May 15, 2023
@bundfussr bundfussr added this to Backlog in admiralonco Project Board via automation May 15, 2023
@bundfussr bundfussr moved this from Backlog to To do - For this sprint in admiralonco Project Board May 15, 2023
@rossfarrugia
Copy link
Contributor

Reminder to also check the admiralonco functions, e.g. derive_param_response() uses the now deprecated derive_param_extreme_event() - spotted during admiralroche updates.

@bundfussr bundfussr moved this from To do - For this sprint to In progress in admiralonco Project Board May 25, 2023
bundfussr added a commit that referenced this issue May 25, 2023
@bundfussr
#216 admiral_0_11_update: remove derive_param_lasta()
0724a0a
bundfussr added a commit that referenced this issue May 25, 2023
@bundfussr
#216 admiral_0_11_update: deprecate aval_fun
370156e
bundfussr added a commit that referenced this issue May 25, 2023
@bundfussr
#216 admiral_0_11_update: style files
ac285bc
bundfussr added a commit that referenced this issue May 26, 2023
@bundfussr
#216 admiral_0_11_update: update ADRS vignette
80fedaa
bundfussr added a commit that referenced this issue Jun 1, 2023
@bundfussr
#216 admiral_0_11_update: update DESCRIPTION
f9875f5
@bundfussr bundfussr linked a pull request Jun 1, 2023 that will close this issue
Closes #216 admiral_0_11_update: Updates due to new admiral version #225
Merged
13 tasks
bundfussr added a commit that referenced this issue Jun 1, 2023
@bundfussr
#216 admiral_0_11_update: update ADRS template
54dfe65
bundfussr added a commit that referenced this issue Jun 1, 2023
@bundfussr
#216 admiral_0_11_update: remove library() calls from tests
5579e71
bundfussr added a commit that referenced this issue Jun 1, 2023
@bundfussr
#216 admiral_0_11_update: fix lintr and R-CMD check
0cc661c
bundfussr added a commit that referenced this issue Jun 1, 2023
@bundfussr
#216 admiral_0_11_update: style files
1b874d2
@bundfussr bundfussr moved this from In progress to In Review in admiralonco Project Board Jun 1, 2023
bundfussr added a commit that referenced this issue Jun 5, 2023
@bundfussr
#216 admiral_0_11_update: add NEWS item
51fc983
bundfussr added a commit that referenced this issue Jun 5, 2023
@bundfussr
#216 admiral_0_11_update: trigger workflows
42d477b
@bundfussr bundfussr moved this from In Review to Done in admiralonco Project Board Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bundfussr bundfussr

Labels
Documentation Material that provides official information or evidence or that serves as a record. release Q2-2023
Projects
admiralonco Project Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #216 admiral_0_11_update: Updates due to new admiral version pharmaverse/admiralonco
2 participants
@bundfussr @rossfarrugia