Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Update PP.PPCAT to more meaningful values #91

Closed
jeffreyad opened this issue Mar 6, 2024 · 1 comment · Fixed by #92
Closed

Feature Request: Update PP.PPCAT to more meaningful values #91

jeffreyad opened this issue Mar 6, 2024 · 1 comment · Fixed by #92
Assignees
@jeffreyad
Labels
enhancement New feature or request

Comments

@jeffreyad
Copy link
Contributor

Feature Idea

I think PPCAT is usually the analyte name. Here it is listed as "COMPARTMENTAL", it may be useful to update this value.

May help resolve pharmaverse/pharmaverseadam#57

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@jeffreyad jeffreyad added the enhancement New feature or request label Mar 6, 2024
@jeffreyad jeffreyad self-assigned this Mar 6, 2024
jeffreyad pushed a commit that referenced this issue Mar 6, 2024
#91 Update PPCAT
89cae1c
@jeffreyad jeffreyad linked a pull request Mar 6, 2024 that will close this issue
Closes #90 #91 Update PPCAT and add urine records #92
Merged
14 tasks
@jeffreyad
Copy link
Contributor Author

@kaz462 we could also add a metabolite here

jeffreyad pushed a commit that referenced this issue Mar 28, 2024
Add urine records #91
b9063f3
jeffreyad pushed a commit that referenced this issue Mar 28, 2024
Run styler #90 #91
ed660c4
manciniedoardo added a commit that referenced this issue Apr 3, 2024
@manciniedoardo
Merge pull request #92 from pharmaverse/91_update_PPCAT
d38fdc6 
Closes #90 #91 Update PPCAT and add urine records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreyad jeffreyad

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #90 #91 Update PPCAT and add urine records pharmaverse/pharmaversesdtm
1 participant
@jeffreyad