Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyw unit tests #199

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Lyw unit tests #199

merged 3 commits into from
Aug 18, 2023

Conversation

laywang142
Copy link
Collaborator

unit tests for:
check_dm_actarm_arm
check_dm_age_missing
check_dm_dthfl_dthdtc
check_dm_usubjid_ae_usubjid
check_ds_ae_discon
check_ds_dsdecod_death
check_ds_dsdecod_dsstdtc
check_ds_dsscat
check_ds_dsterm_death_due_to

Wang, Laura {TBB~SOUTH SAN FRANCISCO} added 2 commits August 17, 2023 00:28
…thfl_dthdtc`, `check_dm_usubjid_ae_usubjid`, `check_ds_ae_discon`
`check_ds_dsdecod_dsstdtc`, `check_ds_dsscat`, `check_ds_dsterm_death_due_to`
@sarabodach sarabodach added the dev Related to testing, versions, workflow, etc. label Aug 17, 2023
@sarabodach
Copy link
Collaborator

Hi @laywang142 ,

Thank you so much for creating these! I ran the covr report and almost all of your new unit test files have 100% coverage. There are two checks that are below 100% because there is one scenario not covered in the unit testing. Could you please include those remaining scenarios? I've pasted the screen captures below.

Thanks a lot!

Sara

=============

check_dm_usubjid_ae_usubjid --> 97.3%
image

check_ds_dsscat --> 95.45%
image

@sarabodach
Copy link
Collaborator

Hi @laywang142 ,

Thank you for incorporating the update so quickly! There's 100% coverage now for these as well-

image
image

Thanks,
Sara

Copy link
Collaborator

@sarabodach sarabodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harriscw - feel free to review as well. No further comments from me. Thanks!

@harriscw
Copy link
Collaborator

@laywang142 Thanks!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@harriscw harriscw merged commit 5515783 into devel Aug 18, 2023
2 checks passed
@harriscw harriscw deleted the LYW_unit_tests branch August 18, 2023 20:25
@sarabodach sarabodach linked an issue Aug 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Related to testing, versions, workflow, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include more unit tests for existing check functions
3 participants