Baseline should be update to not depend anymore on smalltalk/Unicode #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce the sleep time in testReadingFromStdoutAfterCommandFinishesDoesNotBlocksVM to 1 second. There's no value in holding up the tests for 15 seconds and only depending on the process being finished. - #numberOfOpenFiles only cound FIFO (pipes) as the tests are about redirecting stdio and counting all files isn't reliable (causes periodic failures on the CI) - #getStreamsInfoForRunningTest update comments for Pharo 8
|
Fixed one flakey test with 1a5c026 The other test failure appears to be unrelated to this PR. |
Modify the command as per https://docs.travis-ci.com/user/common-build-problems/ in particular don't try and run it as a separate command.
|
02a5dfe is successful in that it now times out after 1 hour instead of 10 minutes. But the test is randomly hanging (not related to this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load Unicode from github repository (was SmalltalkHub).
Fixes: #55