Speedup in AlbTextEditorLineSegmentPieceMap #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes a bit dragging the scroll bar.
See: #34
In my informal profile measurements, I saw a 2x speedup in
selectionRectangles
, still slow.I enclosed this calculation in a
[ ] timeToRun
and log shows between 5ms and 12ms on each execution. Probably we can achieve 0ms by caching. Still understanding what's the motivation of thisselectionRectangles
. Solutions may be caching the result, or count with the inverted Dictionary that it now problematic (one where we search over the keys of it, not the values).Maybe @plantec has an idea