Can't listen mouse right click

[tinchodias]

Check with this snippet:

anElement := BlElement new
	size: 100 asPoint;
	relocate: 50 asPoint;
	background: Color blue;
	when: BlClickEvent do: [ :anEvent | self inform: anEvent button asString ];
	yourself.
	
aSpace := BlSpace new
	addChild: anElement;
	show;
	yourself.

[tinchodias]

This would be fixed if BlMouseProcessor>>#canBeClickEvent:, which is defined as:

canBeClickEvent: aMouseUpEvent
	^ dndInProgress not
		and: [ (previousMouseDownEvent isNotNil and: [ previousMouseDownEvent primaryButtonPressed ])
				and: [ aMouseUpEvent target = previousMouseDownEvent target ] ]

We could use anyButtonPressed instead of only primary* to consider any button. But in fact, since this is a mouse up... just not check like in:

canBeClickEvent: aMouseUpEvent

	^ dndInProgress not and: [ 
		  previousMouseDownEvent isNotNil and: [ 
			  aMouseUpEvent target = previousMouseDownEvent target ] ]

May have a negative impact in brick widgets, such as checkbox, that will start to respond to right click.

[tinchodias]

I see the class comment BlMouseClick now:

The click event is fired when a pointing device button (a mouse's primary button) is pressed and released on a single element.

The order of fired events:

 - Mouse Down
 - Mouse Up
 - Click

May be a more adequate solution than #152 to create a BlRightClick class.

[tinchodias]

Also, it may me convenient (to ease use) to transform BlMouseClick into a hierarchy of

BlMouseClick
   BlPrimaryMouseClick
   BlMiddleMouseClick
   BlSecondaryMouseClick

the names would be consistent with the hierarchy of buttons in BlMouseNamedButton:

(there is also "other button"...)

[tinchodias]

@plantec did you have this issue with right-click in Toplo? I wonder if there is another way to listen right-click that I didn't see.

[plantec]

Hello Martin,
click and other mouse event management within widgets is a nightmare :)
editor, list and buttons have different rules and I think Toplo should be reworked regarding this.

[plantec]

Regarding context menu, two scenarios:
1 - popup on mouse-down and action launched on mouse-up on an item (or menu closed if up outside)
2 - popup on click, then the context menu stays opened until a click outside or a click on an item.
currently, toplo implements the second one but should also implement the first one

[tinchodias]

I added it in Toplo to remember it

[plantec]

I've removed button check from canBeClickEvent: according to your comment. Now, the button can be tested when receiving a click event