Reimplement some explicitly required methods to speed up shapes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#explicitRequirement is really slow in the case were a method is implemented already in the superclass and this slow down a lot some visualizations. I propose to explicitly define the super call to get a huge speed up on shapes (This allows to save a lot of times in the Moose visualizations)
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Mar 11, 2024
## What's Changed * Reimplement some explicitly required methods to speed up shapes by @jecisc in pharo-graphics/Roassal#54 * Make RSAthensMorph apply the world renderer canvas scale factor by @Rinzwind in pharo-graphics/Roassal#56 * Added .gitignore file and Removed DS_Store file by @jordanmontt in pharo-graphics/Roassal#57 * Feature add relative y axis label values by @jordanmontt in pharo-graphics/Roassal#58 ## New Contributors * @jecisc made their first contribution in pharo-graphics/Roassal#54 * @jordanmontt made their first contribution in pharo-graphics/Roassal#57 **Full Changelog**: pharo-graphics/Roassal@v1.03...v1.06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#explicitRequirement is really slow in the case were a method is implemented already in the superclass and this slow down a lot some visualizations. I propose to explicitly define the super call to get a huge speed up on shapes (This allows to save a lot of times in the Moose visualizations)