Update tests #61
Merged
Update tests #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions can require some time to be applied by backend, and this template method can be overriden by subclasses to do something. Do nothing by default. Remove VOMongoTestResource: it's risky to share isntance of repository since some tests set options that can affect other tests. A repository can be created for each test run, it's not slow. I moved the code into VOMongoTest.
|
1 second! is not that A LOT??? |
|
Ah... I thought I wrote something like 100 milliseconds. I'll change it. |
|
It's 50ms now |
|
now we are talking about :) |
zecke
reviewed
Sep 27, 2016
| waitForWriteOperation | ||
| "Write operations can be performed in a fire-and-forget mode, and it's convenient to wait a bit to ensure mongodb performed it before asserting on the results." | ||
|
|
||
| 50 milliSeconds wait |
There was a problem hiding this comment.
Again you can use >>#command: with getLastError and force a sync? Then the last write/delete/op must have succeeded.
There was a problem hiding this comment.
+1 this can be the next step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in this PR:
--> Question: Does anybody use VOMongoTestResource>>mongoHost: to customize the mongodb address? I moved it to VOMongoTest (class side, obviously).