60115

18598 avoid DNU when reapplying rules targeting a package
	https://pharo.fogbugz.com/f/cases/18598

18601 #haltIfNil and deprecated:transformWith: have wrong visual
	https://pharo.fogbugz.com/f/cases/18601

18593 Remove Pharo references to Smalltalk evaluate:
	https://pharo.fogbugz.com/f/cases/18593

15859 review rule RBUncommonMessageSendRule
	https://pharo.fogbugz.com/f/cases/15859

http://files.pharo.org/image/60/60115.zip

Kernel.package/Object.class/instance/deprecation/deprecated_transformWith_.st

@@ -2,7 +2,11 @@ deprecated: anExplanationString transformWith: aRule
 	| rewriteRule method context node |
 	self class environment 
 		at:  #RBParseTreeRewriter 
-		ifAbsent: [ ^self deprecated: anExplanationString ].
+		ifAbsent: [ ^	(Deprecation
+			method: thisContext sender method
+			explanation: anExplanationString
+			on: 'unknown'
+			in: 'unknown') signal ].
 	context := thisContext sender sender.
 	method := context method.
 	node := context sourceNodeExecuted.

Kernel.package/UndefinedObject.class/instance/testing/haltIfNil.st

@@ -1,2 +1,3 @@
 haltIfNil
-	self halt
+	<debuggerCompleteToSender>
+	Halt now

Refactoring-Critics.package/RBUncommonMessageSendRule.class/instance/private/isUnknownCapitalizedMessage_.st

@@ -0,0 +1,2 @@
+isUnknownCapitalizedMessage: aSelector
+	^ aSelector first isUppercase and: [ aSelector isSelectorSymbol not ]

Refactoring-Critics.package/RBUncommonMessageSendRule.class/instance/running/checkMethod_.st

@@ -1,6 +1,6 @@
 checkMethod: aMethod 
 	aMethod messages do: [ :each |
-		(each isEmpty or: [ each first isUppercase or: [ literalNames includes: each ] ]) ifTrue: [
+		(each isEmpty or: [ (self isUnknownCapitalizedMessage: each) or: [ literalNames includes: each ] ]) ifTrue: [
 			result 
 				addMethod: aMethod;
 				addSearchString: each ] ]

Refactoring-Tests-Critics.package/RBSmalllintTest.class/instance/tests/testUncommonMessageSend.st

@@ -1,2 +1,2 @@
 testUncommonMessageSend
-	self ruleFor: self currentSelector
+	self ruleFor: self currentSelector plusSelectors: {#uncommonMessageSend2}

Refactoring-Tests-Critics.package/RBSmalllintTestObject.class/instance/methods/uncommonMessageSend2.st

@@ -0,0 +1,5 @@
+uncommonMessageSend2
+	|a|
+	a:=3
+	Object new.
+	^ a

ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60114.st → ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60115.st

@@ -1,4 +1,4 @@
-script60114
+script60115
 
 	^ 'AST-Core-TheIntegrator.430.mcz
 AST-Tests-Core-TheIntegrator.99.mcz
@@ -132,7 +132,7 @@ IssueTracking-TheIntegrator.6.mcz
 IssueTracking-Tests-TheIntegrator.3.mcz
 Jobs-TheIntegrator.30.mcz
 JobsTests-TheIntegrator.2.mcz
-Kernel-TheIntegrator.2354.mcz
+Kernel-TheIntegrator.2355.mcz
 Kernel-Rules-TheIntegrator.6.mcz
 Kernel-Tests-TheIntegrator.85.mcz
 Kernel-Tests-Rules-TheIntegrator.3.mcz
@@ -248,11 +248,11 @@ Random-Tests-TheIntegrator.4.mcz
 RecentSubmissions-TheIntegrator.244.mcz
 Refactoring-Changes-TheIntegrator.67.mcz
 Refactoring-Core-TheIntegrator.320.mcz
-Refactoring-Critics-TheIntegrator.275.mcz
+Refactoring-Critics-TheIntegrator.276.mcz
 Refactoring-Environment-TheIntegrator.84.mcz
-Refactoring-Tests-Changes-MarcusDenker.38.mcz
+Refactoring-Tests-Changes-TheIntegrator.40.mcz
 Refactoring-Tests-Core-TheIntegrator.135.mcz
-Refactoring-Tests-Critics-TheIntegrator.41.mcz
+Refactoring-Tests-Critics-TheIntegrator.44.mcz
 Refactoring-Tests-Environment-TheIntegrator.27.mcz
 Reflectivity-TheIntegrator.302.mcz
 Reflectivity-Examples-TheIntegrator.35.mcz
@@ -350,7 +350,7 @@ Text-Scanning-TheIntegrator.33.mcz
 Text-Tests-EstebanLorenzano.7.mcz
 Tool-Base-TheIntegrator.161.mcz
 Tool-Catalog-TheIntegrator.40.mcz
-Tool-CriticBrowser-TheIntegrator.30.mcz
+Tool-CriticBrowser-TheIntegrator.31.mcz
 Tool-DependencyAnalyser-ChristopheDemarey.28.mcz
 Tool-DependencyAnalyser-Test-ChristopheDemarey.11.mcz
 Tool-DependencyAnalyser-UI-ChristopheDemarey.43.mcz

ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60115.st

@@ -0,0 +1,15 @@
+update60115
+	"self new update60115"
+	self withUpdateLog: '18598 avoid DNU when reapplying rules targeting a package
+	https://pharo.fogbugz.com/f/cases/18598
+
+18601 #haltIfNil and deprecated:transformWith: have wrong visual
+	https://pharo.fogbugz.com/f/cases/18601
+
+18593 Remove Pharo references to Smalltalk evaluate:
+	https://pharo.fogbugz.com/f/cases/18593
+
+15859 review rule RBUncommonMessageSendRule
+	https://pharo.fogbugz.com/f/cases/15859'.
+	self loadTogether: self script60115 merge: false.
+	self flushCaches.

ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st

@@ -1,15 +1,12 @@
 commentForCurrentUpdate
- ^ '18614 add a "Debug" menu for halt / breakpoints
-	https://pharo.fogbugz.com/f/cases/18614
+ ^ '18598 avoid DNU when reapplying rules targeting a package
+	https://pharo.fogbugz.com/f/cases/18598
 
-18599 use sendsAnySelectorOf: in RBBadMessageRule
-	https://pharo.fogbugz.com/f/cases/18599
+18601 #haltIfNil and deprecated:transformWith: have wrong visual
+	https://pharo.fogbugz.com/f/cases/18601
 
-18611 Fix warnings that refer to inexistant methods (maxExternalObjects & maxExternalObjectsSilently:)
-	https://pharo.fogbugz.com/f/cases/18611
+18593 Remove Pharo references to Smalltalk evaluate:
+	https://pharo.fogbugz.com/f/cases/18593
 
-18305 MCWorkingCopyBrowser class>>#order would benefit to have a comment
-	https://pharo.fogbugz.com/f/cases/18305
-
-18605 add DoOnlyOnceIconStyler
-	https://pharo.fogbugz.com/f/cases/18605'
+15859 review rule RBUncommonMessageSendRule
+	https://pharo.fogbugz.com/f/cases/15859'

Tool-CriticBrowser.package/CriticsCache.class/instance/add%2Fremove/removeFalsePositive_forRule_.st

@@ -2,7 +2,9 @@ removeFalsePositive: aCritic forRule: aRule
 
 	(falsePositives includesKey: aRule) 
 		ifFalse: [^ self].
-	(falsePositiveClasses includes: aCritic criticTheNonMetaclassClass) 
-			ifTrue: [^ self].
+	[ (falsePositiveClasses includes: aCritic criticTheNonMetaclassClass) 
+			ifTrue: [^ self] ]
+		on: MessageNotUnderstood 
+		do: [ ^ self "#criticTheNonMetaclassClass makes no sense on a Package, ignore"].
 	(falsePositives at: aRule) remove: aCritic ifAbsent: [^ self].
-	self updateBrowser
+	self updateBrowser