Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
15564 Association key:value: https://pharo.fogbugz.com/f/cases/15564 15549 "References an abstract class" should check method https://pharo.fogbugz.com/f/cases/15549 15566 Direct dependency from CompiledMethod to the bytecode set https://pharo.fogbugz.com/f/cases/15566 15523 Code Cruft Rule Only Matches One-Liners https://pharo.fogbugz.com/f/cases/15523 http://files.pharo.org/image/50/50053.zip
- Loading branch information
Jenkins Build Server
authored and
ci
committed
May 20, 2015
1 parent
d024c98
commit 2e7d6b2
Showing
43 changed files
with
209 additions
and
87 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
Collections-Strings.package/Symbol.class/instance/converting/separateKeywords.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/isAlternateBytecodeSet.st
This file was deleted.
Oops, something went wrong.
27 changes: 27 additions & 0 deletions
27
Compiler.package/EncoderForSistaV1.class/class/compiled method support/markerOrNilFor_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| markerOrNilFor: compiledMethod | ||
| "What is a marker method? It is method with body like | ||
| 'self subclassResponsibility' or '^ self subclassResponsibility' | ||
| used to indicate ('mark') a special property. | ||
| Marker methods compile to bytecode like: | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <87> pop | ||
| 12 <78> returnSelf | ||
| for the first form, or | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <7C> returnTop | ||
| for the second form." | ||
|
|
||
| | e | | ||
| ((e := compiledMethod endPC) = 19 or: [e = 20]) ifFalse: [^ nil]. | ||
| (compiledMethod numLiterals = 3) ifFalse:[^ nil]. | ||
| (compiledMethod at: 17) = 76 ifFalse:[^ nil]. "push self" | ||
| (compiledMethod at: 18) = 128 ifFalse:[^ nil]. "send <literal 1>" | ||
| "If we reach this point, we have a marker method that sends self <literal 1>" | ||
| ^ compiledMethod literalAt: 1 |
2 changes: 2 additions & 0 deletions
2
...EncoderForSistaV1.class/class/compiled method support/prepareMethod_forSimulationWith_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| prepareMethod: compiledMethod forSimulationWith: numArgs | ||
| self shouldBeImplemented |
6 changes: 6 additions & 0 deletions
6
Compiler.package/EncoderForSistaV1.class/class/compiled method support/sendsToSuperFor_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| sendsToSuperFor: compiledMethod | ||
| "Answer whether the receiver sends any message to super." | ||
| | scanner | | ||
| scanner := InstructionStream on: compiledMethod. | ||
| ^ scanner scanFor: | ||
| [:instr | instr = 235 ] |
2 changes: 0 additions & 2 deletions
2
....package/EncoderForV3PlusClosures.class/class/bytecode decoding/isAlternateBytecodeSet.st
This file was deleted.
Oops, something went wrong.
27 changes: 27 additions & 0 deletions
27
...r.package/EncoderForV3PlusClosures.class/class/compiled method support/markerOrNilFor_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| markerOrNilFor: compiledMethod | ||
| "What is a marker method? It is method with body like | ||
| 'self subclassResponsibility' or '^ self subclassResponsibility' | ||
| used to indicate ('mark') a special property. | ||
| Marker methods compile to bytecode like: | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <87> pop | ||
| 12 <78> returnSelf | ||
| for the first form, or | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <7C> returnTop | ||
| for the second form." | ||
|
|
||
| | e | | ||
| ((e := compiledMethod endPC) = 19 or: [e = 20]) ifFalse: [^ nil]. | ||
| (compiledMethod numLiterals = 3) ifFalse:[^ nil]. | ||
| (compiledMethod at: 17) = 16r70 ifFalse:[^ nil]. "push self" | ||
| (compiledMethod at: 18) = 16rD0 ifFalse:[^ nil]. "send <literal 1>" | ||
| "If we reach this point, we have a marker method that sends self <literal 1>" | ||
| ^ compiledMethod literalAt: 1 |
8 changes: 8 additions & 0 deletions
8
...ForV3PlusClosures.class/class/compiled method support/prepareMethod_forSimulationWith_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| prepareMethod: compiledMethod forSimulationWith: numArgs | ||
| | xpc | | ||
| xpc := compiledMethod initialPC. | ||
| "long store temp" | ||
| (compiledMethod at: xpc) = 129 | ||
| ifTrue: [ | ||
| compiledMethod at: xpc + 1 put: (16r40 + numArgs). | ||
| compiledMethod at: xpc + 3 put: (16r10 + numArgs)] |
7 changes: 7 additions & 0 deletions
7
....package/EncoderForV3PlusClosures.class/class/compiled method support/sendsToSuperFor_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| sendsToSuperFor: compiledMethod | ||
| "Answer whether the receiver sends any message to super." | ||
| | scanner | | ||
| scanner := InstructionStream on: compiledMethod. | ||
| ^ scanner scanFor: | ||
| [:instr | instr = 16r85 or: [instr = 16r84 | ||
| and: [scanner followingByte between: 16r20 and: 16r3F]]] |
9 changes: 2 additions & 7 deletions
9
Kernel.package/CompiledMethod.class/instance/debugger support/prepareForSimulationWith_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,11 @@ | ||
| prepareForSimulationWith: numArgs | ||
| "This method changes the argument count of a CompiledMethod header to numArgs, its temporary count to numArgs + 1 and change the code handling primitive error to store the error code in the unique temporary of the method" | ||
|
|
||
| | newHeader xpc | | ||
| | newHeader | | ||
| newHeader := (((self header bitAnd: 2r01110000000000111111111111111111) | ||
| bitOr: (numArgs bitShift: 24)) | ||
| bitOr: (numArgs + 1 bitShift: 18)). | ||
| newHeader := newHeader + (self class headerFlagForEncoder: self encoderClass). | ||
| self objectAt: 1 put: newHeader. | ||
|
|
||
| xpc := self initialPC. | ||
| "long store temp" | ||
| (self at: xpc) = 129 | ||
| ifTrue: [ | ||
| self at: xpc + 1 put: (16r40 + numArgs). | ||
| self at: xpc + 3 put: (16r10 + numArgs)] | ||
| self encoderClass prepareMethod: self forSimulationWith: numArgs |
30 changes: 1 addition & 29 deletions
30
Kernel.package/CompiledMethod.class/instance/private/markerOrNil.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,2 @@ | ||
| markerOrNil | ||
| "If I am a marker method, answer the symbol used to mark me. Otherwise | ||
| answer nil. | ||
| What is a marker method? It is method with body like | ||
| 'self subclassResponsibility' or '^ self subclassResponsibility' | ||
| used to indicate ('mark') a special property. | ||
| Marker methods compile to bytecode like: | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <87> pop | ||
| 12 <78> returnSelf | ||
| for the first form, or | ||
| 9 <70> self | ||
| 10 <D0> send: <literal 1> | ||
| 11 <7C> returnTop | ||
| for the second form." | ||
|
|
||
| | e | | ||
| ((e := self endPC) = 19 or: [e = 20]) ifFalse: [^ nil]. | ||
| (self numLiterals = 3) ifFalse:[^ nil]. | ||
| (self at: 17) = 16r70 ifFalse:[^ nil]. "push self" | ||
| (self at: 18) = 16rD0 ifFalse:[^ nil]. "send <literal 1>" | ||
| "If we reach this point, we have a marker method that sends self <literal 1>" | ||
| ^ self literalAt: 1 | ||
| ^ self encoderClass markerOrNilFor: self |
7 changes: 1 addition & 6 deletions
7
Kernel.package/CompiledMethod.class/instance/scanning/sendsToSuper.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,2 @@ | ||
| sendsToSuper | ||
| "Answer whether the receiver sends any message to super." | ||
| | scanner | | ||
| scanner := InstructionStream on: self. | ||
| ^ scanner scanFor: | ||
| [:instr | instr = 16r85 or: [instr = 16r84 | ||
| and: [scanner followingByte between: 16r20 and: 16r3F]]] | ||
| ^ self encoderClass sendsToSuperFor: self |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| halt | ||
| "This is the typical message to use for inserting breakpoints during debugging." | ||
| <debuggerCompleteToSender> | ||
| Halt now |
3 changes: 3 additions & 0 deletions
3
Kernel.package/Object.class/instance/halting/haltIfShiftPressed.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| haltIfShiftPressed | ||
| <debuggerCompleteToSender> | ||
| Halt ifShiftPressed. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| haltIf: condition | ||
| <debuggerCompleteToSender> | ||
| Halt if: condition. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| haltOnCount: anInteger | ||
| <debuggerCompleteToSender> | ||
| Halt onCount: anInteger. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| haltOnce | ||
| <debuggerCompleteToSender> | ||
| Halt once. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| halt: aString | ||
| <debuggerCompleteToSender> | ||
| Halt now: aString |
2 changes: 0 additions & 2 deletions
2
Refactoring-Critics.package/RBAbstractClassRule.class/instance/accessing/resultClass.st
This file was deleted.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
Refactoring-Critics.package/RBAbstractClassRule.class/instance/accessing/severity.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| severity | ||
|
|
||
| ^ #information |
3 changes: 0 additions & 3 deletions
3
Refactoring-Critics.package/RBAbstractClassRule.class/instance/initialization/initialize.st
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
Refactoring-Critics.package/RBAbstractClassRule.class/instance/running/checkClass_.st
This file was deleted.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
Refactoring-Critics.package/RBAbstractClassRule.class/instance/running/checkMethod_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| checkMethod: aMethod | ||
| aMethod referencedClasses | ||
| detect: [ :class | | ||
| class methods anySatisfy: #isAbstract ] | ||
| ifFound: [ :class | | ||
| result | ||
| addMethod: aMethod; | ||
| addSearchString: class name ] |
3 changes: 1 addition & 2 deletions
3
...-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/initialization/initialize.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| initialize | ||
| super initialize. | ||
| #('`@object clearHaltOnce' '`@object doOnlyOnce: `@object1' '`@object halt' '`@object halt: `@object1 onCount: `@object2' '`@object haltOnCount: `@object1' '`@object haltOnce' '`@object haltIf: `@object1' '`@object inspectOnCount: `@object1' '`@object inspectOnce' '`@object inspectUntilCount: `@object1' '`@object rearmOneShot' '`@object setHaltOnce' '`@object flag: `@object1' '`@object isThisEverCalled' '`@object isThisEverCalled: `@object1' '`@object logEntry' '`@object logExecution' '`@object logExit' '`@object needsWork' 'Transcript `@message: `@object1') | ||
| do: [ :matchingString | self rewriteRule replace: matchingString with: '' ] | ||
| self patterns do: [ :halt | self addRuleRemoving: halt ] |
11 changes: 11 additions & 0 deletions
11
...g-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/addRuleRemoving_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| addRuleRemoving: patternString | ||
| "When you are completely removing statement(s), you can not just match the relevant node. You must match the whole method and then replace it minus the part to be removed" | ||
|
|
||
| | findString replaceString methodTemplate | | ||
| methodTemplate := '| `@Temps | | ||
| ``@.Statements1. | ||
| {1}. | ||
| ``@.Statements2'. | ||
| findString := methodTemplate format: { patternString }. | ||
| replaceString := methodTemplate format: { '' }. | ||
| self rewriteRule replace: findString with: replaceString |
4 changes: 4 additions & 0 deletions
4
...-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/debuggingPatterns.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| debuggingPatterns | ||
| | result | | ||
| result := self debuggingSelectors collect: [ :e | self patternFor: e ]. | ||
| ^ result, { 'Transcript `@message: `@arg' } |
4 changes: 4 additions & 0 deletions
4
...Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/debuggingSelectors.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| debuggingSelectors | ||
|
|
||
| ^ (Object allSelectorsInProtocol: 'flagging'), | ||
| (Object allSelectorsInProtocol: 'debugging') |
4 changes: 4 additions & 0 deletions
4
...oring-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/haltPatterns.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| haltPatterns | ||
| | result | | ||
| result := self haltSelectors collect: [ :e | self patternFor: e ]. | ||
| ^ result, { 'Halt `@message: `@arg' } |
5 changes: 5 additions & 0 deletions
5
...ring-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/haltSelectors.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| haltSelectors | ||
| | objectConvenience miscellaneous | | ||
| objectConvenience := Object allSelectorsInProtocol: #halting. | ||
| miscellaneous := #(clearHaltOnce inspectOnce setHaltOnce). | ||
| ^ objectConvenience, miscellaneous |
14 changes: 14 additions & 0 deletions
14
...package/RBCodeCruftLeftInMethodsRule.class/instance/private/patternForKeywordSelector_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| patternForKeywordSelector: selector | ||
| | index | | ||
| ^ String streamContents: [ :str | | ||
| str nextPutAll: '`@object '. | ||
| index := 1. | ||
| selector keywords | ||
| do: [ :keyword | | ||
| str | ||
| nextPutAll: keyword; | ||
| nextPutAll: ' `@arg'; | ||
| print: index ] | ||
| separatedBy: [ | ||
| index := index + 1. | ||
| str space ] ] |
4 changes: 4 additions & 0 deletions
4
...toring-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/patternFor_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| patternFor: selector | ||
| selector isUnary ifTrue: [ ^ '`@object ', selector ]. | ||
| selector isBinary ifTrue: [ ^ '`@object ', selector, ' `@arg' ]. | ||
| ^ self patternForKeywordSelector: selector |
2 changes: 2 additions & 0 deletions
2
Refactoring-Critics.package/RBCodeCruftLeftInMethodsRule.class/instance/private/patterns.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| patterns | ||
| ^ self debuggingPatterns, self haltPatterns |
2 changes: 1 addition & 1 deletion
2
...-Tests-Critics.package/RBSmalllintTest.class/instance/tests/testCodeCruftLeftInMethods.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| testCodeCruftLeftInMethods | ||
| self ruleFor: self currentSelector | ||
| self ruleFor: self currentSelector plusSelectors: #(haltClassMentioned flagged transcriptMentioned debbuggingMessageSent) |
8 changes: 7 additions & 1 deletion
8
...ts-Critics.package/RBSmalllintTestObject.class/instance/methods/codeCruftLeftInMethods.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| codeCruftLeftInMethods | ||
| self halt | ||
| | a b c | | ||
| a := b := c := 2. | ||
| self halt. | ||
| ^ a > 0 | ||
| ifTrue: [ b ] | ||
| ifFalse: [ c ] | ||
|
|
2 changes: 2 additions & 0 deletions
2
...sts-Critics.package/RBSmalllintTestObject.class/instance/methods/debbuggingMessageSent.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| debbuggingMessageSent | ||
| self rearmOneShot |
2 changes: 2 additions & 0 deletions
2
Refactoring-Tests-Critics.package/RBSmalllintTestObject.class/instance/methods/flagged.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| flagged | ||
| self flag: 'to do'. |
2 changes: 2 additions & 0 deletions
2
...-Tests-Critics.package/RBSmalllintTestObject.class/instance/methods/haltClassMentioned.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| haltClassMentioned | ||
| Halt now |
2 changes: 2 additions & 0 deletions
2
...Tests-Critics.package/RBSmalllintTestObject.class/instance/methods/transcriptMentioned.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| transcriptMentioned | ||
| Transcript show: 'message' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.