Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
19809 Failing test: WeakAnnouncerTest>>#testNoDeadWeakSubscriptions https://pharo.fogbugz.com/f/cases/19809 19799 Nautilus rebuilds the package view twice when adding a new protocol https://pharo.fogbugz.com/f/cases/19799 19810 Non weak announcements in the SystemAnnouncer https://pharo.fogbugz.com/f/cases/19810 http://files.pharo.org/image/60/60433.zip
- Loading branch information
Jenkins Build Server
authored and
ci
committed
Mar 7, 2017
1 parent
2277855
commit e72b6dd
Showing
9 changed files
with
50 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 6 additions & 1 deletion
7
Reflectivity.package/ReflectiveMethod.class/instance/accessing/compiledMethod_.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| compiledMethod: aCompiledMethod | ||
|
|
||
| compiledMethod := aCompiledMethod. | ||
| class := aCompiledMethod methodClass. | ||
| ast := compiledMethod ast. | ||
| SystemAnnouncer uniqueInstance when: ASTCacheReset send: #reinstallASTInCache to: self | ||
|
|
||
| SystemAnnouncer uniqueInstance weak | ||
| when: ASTCacheReset | ||
| send: #reinstallASTInCache | ||
| to: self |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60432.st
This file was deleted.
Oops, something went wrong.
14 changes: 14 additions & 0 deletions
14
ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60433.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| update60433 | ||
| "self new update60433" | ||
| self withUpdateLog: '19809 Failing test: WeakAnnouncerTest>>#testNoDeadWeakSubscriptions | ||
| https://pharo.fogbugz.com/f/cases/19809 | ||
| 19799 Nautilus rebuilds the package view twice when adding a new protocol | ||
| https://pharo.fogbugz.com/f/cases/19799 | ||
| 19810 Non weak announcements in the SystemAnnouncer | ||
| https://pharo.fogbugz.com/f/cases/19810'. | ||
| self loadTogether: self script60433 merge: false. | ||
|
|
||
| (SystemAnnouncer uniqueInstance subscriptions glmSubscriptions select: [:sub | sub subscriber isNil]) do: #finalize. 3 timesRepeat: [Smalltalk garbageCollect ]. | ||
| self flushCaches. |
12 changes: 6 additions & 6 deletions
12
ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| commentForCurrentUpdate | ||
| ^ '19808 add timeout and cache per session to catalog | ||
| https://pharo.fogbugz.com/f/cases/19808 | ||
| ^ '19809 Failing test: WeakAnnouncerTest>>#testNoDeadWeakSubscriptions | ||
| https://pharo.fogbugz.com/f/cases/19809 | ||
| 19803 MCSTWriterTest>>#testMethodDefinitionWithBangs failing on bootstrapped image | ||
| https://pharo.fogbugz.com/f/cases/19803 | ||
| 19799 Nautilus rebuilds the package view twice when adding a new protocol | ||
| https://pharo.fogbugz.com/f/cases/19799 | ||
| 19811 some methods are wrong in DynamicLoader | ||
| https://pharo.fogbugz.com/f/cases/19811' | ||
| 19810 Non weak announcements in the SystemAnnouncer | ||
| https://pharo.fogbugz.com/f/cases/19810' |
12 changes: 8 additions & 4 deletions
12
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testNoDeadSubscriptions.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| testNoDeadSubscriptions | ||
|
|
||
| | dead | | ||
|
|
||
| 3 timesRepeat: [ Smalltalk garbageCollect ]. | ||
|
|
||
| self deny: ( | ||
| (SystemAnnouncer uniqueInstance subscriptions instVarNamed: #subscriptions) anySatisfy: [ :sub | | ||
| sub subscriber isNil ] | ||
| ) | ||
| dead := SystemAnnouncer uniqueInstance | ||
| subscriptions subscriptions select: [ :sub | | ||
| sub subscriber isNil | ||
| ]. | ||
|
|
||
| self assert: dead asArray equals: #() |
13 changes: 8 additions & 5 deletions
13
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testOnlyWeakSubscriptions.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| testOnlyWeakSubscriptions | ||
|
|
||
| "only weak subscriptions should be allowed to be added to the SystemAnnouncer..." | ||
| | strong | | ||
|
|
||
| "only weak subscriptions should be allowed to be added to the SystemAnnouncer..." | ||
|
|
||
| strong := SystemAnnouncer uniqueInstance | ||
| subscriptions subscriptions reject: [ :each | | ||
| each isKindOf: WeakAnnouncementSubscription | ||
| ]. | ||
|
|
||
| "self assert: ( | ||
| (SystemAnnouncer uniqueInstance subscriptions instVarNamed: #subscriptions) | ||
| allSatisfy: [ :sub | sub isKindOf: WeakAnnouncementSubscription ] | ||
| )" | ||
| self assert: strong asArray equals: #() |
2 changes: 1 addition & 1 deletion
2
Tests.package/SystemAnnouncerLiveTest.class/instance/tests/testSaneSubscriptionSize.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| testSaneSubscriptionSize | ||
|
|
||
| self flag: 'this should be a release test, not a regular one' | ||
| "self flag: 'this should be a release test, not a regular one'" | ||
| "self assert: SystemAnnouncer uniqueInstance subscriptions numberOfSubscriptions < 75." |