fix #240 - command could fail if dialog canceled

src/PharoLauncher-Core.package/PhLCommand.class/instance/executeCommand.st

@@ -0,0 +1,5 @@
+action
+executeCommand
+	[ self execute ]
+		on: PhLCommandCancellation
+		do: [ :ex | "Do nothing - user has cancelled the command" ].

src/PharoLauncher-Core.package/PhLCommand.class/instance/executeIfApplicable.st

@@ -1,4 +1,4 @@
 action
 executeIfApplicable
 	self isApplicable ifTrue: [ 
-		self validateModelIntegrity ifTrue: [self execute ]]
+		self validateModelIntegrity ifTrue: [self executeCommand ]]

src/PharoLauncher-Core.package/PhLCommandCancellation.class/README.md

@@ -0,0 +1 @@
+Get notified if a user canceled an operation do not run following operations if any

src/PharoLauncher-Core.package/PhLCommandCancellation.class/properties.json

@@ -0,0 +1,11 @@
+{
+	"commentStamp" : "ChristopheDemarey 9/12/2018 12:27",
+	"super" : "Notification",
+	"category" : "PharoLauncher-Core-Model",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "PhLCommandCancellation",
+	"type" : "normal"
+}

src/PharoLauncher-Core.package/PhLCreateTemplateFromImageAndRemoveImageCommand.class/instance/createTemplate.st

@@ -2,6 +2,7 @@ action
 createTemplate
 	| name |
 	name := self newTemplateName.
+	name ifNil: [ PhLCommandCancellation signal ].
 	self
 		ensure: (self model isNewLocalTemplateNameValid: name).
 	self model templateRepository

src/PharoLauncher-Core.package/PhLCreateTemplateFromImageCommand.class/instance/execute.st

@@ -2,5 +2,6 @@ action
 execute
 	| name |
 	name := self newTemplateName.
-	self ensure: name isEmptyOrNil not.
+	name ifNil: [ PhLCommandCancellation signal ].
+	self ensure: name isNotEmpty.
 	self model templateRepository createLocalTemplateFrom: self model singleImage named: name