Restoring signalFinalization: of weak objects for backwards compatibi…

…lity
pharo-project · Jan 23, 2023 · 621ecf4 · 621ecf4
1 parent 1092645
commit 621ecf4
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/smalltalksrc/VMMaker/SpurMemoryManager.class.st b/smalltalksrc/VMMaker/SpurMemoryManager.class.st
@@ -8935,8 +8935,13 @@ SpurMemoryManager >> nilUnmarkedWeaklingSlots [
 	<inline: #never>
 	self eassert: [ self allOldMarkedWeakObjectsOnWeaklingStack ].
 	weaklingStack = nilObj ifTrue: [ ^ self ].
-	self objStack: weaklingStack from: 0 do: [ :weakling |
-		self nilUnmarkedWeaklingSlotsIn: weakling ].
+	self objStack: weaklingStack from: 0 do: [ :weakling | | anyUnmarked |
+		anyUnmarked := self nilUnmarkedWeaklingSlotsIn: weakling.
+		anyUnmarked ifTrue:
+			["fireFinalization: could grow the mournQueue and if so,
+			  additional pages must be marked to avoid being GC'ed."
+			 self assert: marking.
+			 coInterpreter signalFinalization: weakling]].
 	self emptyObjStack: weaklingStack
 ]