Type guided '&' translation #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivojawer
changed the title
guillep
reviewed
Aug 28, 2023
| | receiver result | | ||
|
|
||
| receiver := 1000. | ||
| result := receiver & false |
There was a problem hiding this comment.
What if the boolean is an argument?
methodWithAndIntegerReceiverAndBooleanArgument: arg [
| receiver result |
receiver := 1000.
result := receiver & argand all variantas :)
- boolean & boolean
- boolean & int
- int & boolean
- int & int
There was a problem hiding this comment.
The cases where both (arg and receiver) are boolean/int are covered with methodWithAndBooleanReceiver and methodWithAndIntegerReceiver. Maybe the name should reference the argument 馃槄
The other cases I considered them all the same test case (covered by this method), as they fall under the "if they are different types then throw an error" logic.
There was a problem hiding this comment.
Yes, but my point is that those tests are on literal booleans/integers!!!
What if the receiver are the result of a more complex expression, say a variable? Do we need a type annotation for booleans?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #663
Generates CAST for the
&send node (checkCCodeGenerator >> generateCASTInferredAnd: aTSendNode) depending on the type of the receiver and argument&&&A
TTypeobject was implemented to replace some types, yet most operations are still string-based 馃槩