Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retain any selectors in CogAbstractInstruction #798

Merged

Conversation

RenaudFondeur
Copy link
Contributor

CogAbstractInstruction implements an overly conservative version of requiredMethodNames:.
This provokes the retaining of lots of methods that should not be retained.

Fix #786

@guillep guillep marked this pull request as ready for review May 13, 2024 13:57
@guillep
Copy link
Member

guillep commented May 13, 2024

CI went ok! Thanks @RenaudFondeur !

@guillep guillep merged commit b073bca into pharo-project:pharo-10 May 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Slang to not generate functions with no senders *after* doing the inlinings
2 participants