Skip to content

Commit

Permalink
Fix broken test RBRemoveClassKeepingSubclassesTest >> testRemoveNotEm…
Browse files Browse the repository at this point in the history
…ptySuperclass (has invalid reference)
  • Loading branch information
Lin777 committed Dec 4, 2020
1 parent 601a6b7 commit 02153e1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
Expand Up @@ -11,16 +11,19 @@ RBRemoveClassKeepingSubclassesTest >> testRemoveClassWithReferencesRaisesRBRefac

{ #category : #tests }
RBRemoveClassKeepingSubclassesTest >> testRemoveNotEmptySuperclass [
| refactoring class |
refactoring := RBRemoveClassKeepingSubclassesRefactoring classNames: (Array with: ('RBTransformation' , 'RuleTestData1') asSymbol).
class := refactoring model classNamed: ('RBTransformation' , 'RuleTestData2') asSymbol.

| refactoring class removedClass subclass |

removedClass := ('RBTransformation' , 'RuleTestData1') asSymbol.
subclass := ('RBTransformation' , 'RuleTestData2') asSymbol.
refactoring := RBRemoveClassKeepingSubclassesRefactoring classNames:
{ removedClass }.
class := refactoring model classNamed: subclass.
self deny: (class directlyDefinesMethod: #foo).
self executeRefactoring: refactoring.
self assert: (refactoring model classNamed: ('RBTransformation' , 'RuleTestData1') asSymbol) isNil.
self assert: (refactoring model classNamed: ('RBTransformation', 'RuleTestData2')
asSymbol) superclass equals: (refactoring model classNamed: #RBFooLintRuleTestData1).
class := refactoring model classNamed: ('RBTransformation', 'RuleTestData2')
asSymbol.
self assert: (class directlyDefinesMethod: #foo).

self assert: (refactoring model classNamed: removedClass) isNil.
self
assert: class superclass
equals: (refactoring model classNamed: #RBFooLintRuleTestData1).
self assert: (class directlyDefinesMethod: #foo)
]
5 changes: 3 additions & 2 deletions src/Refactoring-Tests-Core/RBRemoveClassTest.class.st
Expand Up @@ -12,8 +12,9 @@ RBRemoveClassTest >> resumeOnCannotRemoveTopLevelClassError: error [

{ #category : #'failure tests' }
RBRemoveClassTest >> testRaisesRBRefactoringErrorWhenRemovingNonEmptySuperclass [

self shouldFail: (RBRemoveClassRefactoring classNames: {#RBTransformationRuleTestData1})
|class|
class := ('RBTransformation', 'RuleTestData1') asSymbol.
self shouldFail: (RBRemoveClassRefactoring classNames: {class})
]

{ #category : #tests }
Expand Down

0 comments on commit 02153e1

Please sign in to comment.