- #notifty:at: is just used in OCSemanticError Hierarchy, remove it f…

…rom OCSemanticWarning - OCReadOnlyVMWarning is not needed anymore: all VMs support read only objects - add #requestor to OCSemanticError and simplify notify:at: there
pharo-project · May 13, 2020 · 2cd549c · 2cd549c
1 parent f4de0cb
commit 2cd549c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 58 deletions.
diff --git a/src/OpalCompiler-Core/CompilationContext.class.st b/src/OpalCompiler-Core/CompilationContext.class.st
@@ -274,8 +274,6 @@ CompilationContext class >> optionReadOnlyLiterals [
 
 { #category : #'options - settings API' }
 CompilationContext class >> optionReadOnlyLiterals: aBoolean [
-	(aBoolean and: [ Smalltalk vm supportsWriteBarrier not]) ifTrue: [ ^ OCReadOnlyVMWarning signal ].
-
 	^ self writeDefaultOption: #optionReadOnlyLiterals value: aBoolean
 ]
 

diff --git a/src/OpalCompiler-Core/OCReadOnlyVMWarning.class.st b/src/OpalCompiler-Core/OCReadOnlyVMWarning.class.st
diff --git a/src/OpalCompiler-Core/OCSemanticError.class.st b/src/OpalCompiler-Core/OCSemanticError.class.st
@@ -23,7 +23,7 @@ OCSemanticError >> compilationContext: anObject [
 
 { #category : #exceptiondescription }
 OCSemanticError >> defaultAction [
-	^self notify:  messageText at: node start.
+	^self notify: messageText at: node start
 ]
 
 { #category : #accessing }
@@ -48,17 +48,20 @@ OCSemanticError >> node: aNode [
 
 { #category : #'error handling' }
 OCSemanticError >> notify: aString at: location [
-	"Refer to the comment in Object|notify:."
-
-	^compilationContext requestor 
+	^self requestor 
 		ifNil: [SyntaxErrorNotification
 					inClass: self methodClass 
 					withCode: self methodNode source
 					doitFlag: false
 					errorMessage: aString
 					location: location]
-		ifNotNil: [compilationContext requestor
+		ifNotNil: [self requestor
 					notify: aString , ' ->'
 					at: location
-					in: compilationContext requestor text]
+					in: self requestor text]
+]
+
+{ #category : #accessing }
+OCSemanticError >> requestor [
+	^ compilationContext requestor
 ]
diff --git a/src/OpalCompiler-Core/OCSemanticWarning.class.st b/src/OpalCompiler-Core/OCSemanticWarning.class.st
@@ -67,23 +67,6 @@ OCSemanticWarning >> node: anObject [
 	node := anObject
 ]
 
-{ #category : #correcting }
-OCSemanticWarning >> notify: aString at: location [
-	"Refer to the comment in Object|notify:."
-
-	^self requestor 
-		ifNil: [SyntaxErrorNotification
-					inClass: self methodClass 
-					withCode: self methodNode source
-					doitFlag: false
-					errorMessage: aString
-					location: location]
-		ifNotNil: [self requestor
-					notify: aString , ' ->'
-					at: location
-					in: self requestor text]
-]
-
 { #category : #correcting }
 OCSemanticWarning >> openMenuIn: aBlock [
 	self subclassResponsibility